Page MenuHomeFreeBSD
Differential D26037

Add test to verify fix for FreeBSD-SA-19:20.bsnmp
ClosedPublic
Actions

Authored by darrick.freebsd_gmail.com on Aug 12 2020, 12:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 25, 6:01 AM
Unknown Object (File)
Mon, Jun 22, 8:09 PM
Unknown Object (File)
Mon, Jun 22, 1:15 AM
Unknown Object (File)
Thu, Jun 18, 7:00 PM
Unknown Object (File)
Mon, Jun 15, 6:33 PM
Unknown Object (File)
Mon, Jun 15, 3:37 PM
Unknown Object (File)
Mon, Jun 15, 3:36 PM
Unknown Object (File)
Mon, Jun 15, 3:36 PM
View All Files
Subscribers
imp

Details

Reviewers
cem
vangyzen
Group Reviewers
tests
Commits
rS364221: Add test to for FreeBSD-SA-19:20.bsnmp
Summary

Verify passing in improper length in asn_buf to asn_get_header() returns ASN_ERR_EOBUF.

Test Plan

Verified test passing with fix for FreeBSD-SA-19:20.bsnmp and failing without.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32935
Build 30333: arc lint + arc unit

Event Timeline

darrick.freebsd_gmail.com requested review of this revision.Aug 12 2020, 12:18 AM
darrick.freebsd_gmail.com created this revision.
Harbormaster completed remote builds in B32934: Diff 75711.Aug 12 2020, 12:18 AM
cem added a reviewer: tests.Aug 12 2020, 12:23 AM
cem added inline comments.
lib/libbsnmp/tests/bsnmpd_test.c
10

The explicit length can be dropped to size it correctly automatically, char test_buf[] = { ... };

16

2, or sizeof(test_buf)

darrick.freebsd_gmail.com updated this revision to Diff 75712.Aug 12 2020, 12:32 AM

Update per CR feedback.

Harbormaster completed remote builds in B32935: Diff 75712.Aug 12 2020, 12:32 AM
cem added inline comments.Aug 12 2020, 12:45 AM
lib/libbsnmp/tests/bsnmpd_test.c
16

this one was missed?

darrick.freebsd_gmail.com updated this revision to Diff 75713.Aug 12 2020, 1:31 AM

Update per CR feedback.

Harbormaster completed remote builds in B32936: Diff 75713.Aug 12 2020, 1:31 AM
cem accepted this revision.Aug 12 2020, 8:44 PM
This revision is now accepted and ready to land.Aug 12 2020, 8:44 PM
Closed by commit rS364221: Add test to for FreeBSD-SA-19:20.bsnmp (authored by bdrewery). · Explain WhyAug 13 2020, 10:42 PM
This revision was automatically updated to reflect the committed changes.
bdrewery added a commit: rS364221: Add test to for FreeBSD-SA-19:20.bsnmp.
Herald added a subscriber: imp. · View Herald TranscriptAug 13 2020, 10:42 PM

Revision Contents
Changeset List

PathSize
lib/
libbsnmp/
1 line
tests/
11 lines
25 lines

Diff 75712

View Options

lib/libbsnmp/Makefile

Loading...
View Options

lib/libbsnmp/tests/Makefile

Loading...
View Options

lib/libbsnmp/tests/bsnmpd_test.c

Loading...