Page MenuHomeFreeBSD

darrick.freebsd_gmail.com (Darrick Lew)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 24 2018, 7:57 PM (148 w, 6 h)

Recent Activity

Aug 12 2020

darrick.freebsd_gmail.com updated the diff for D26037: Add test to verify fix for FreeBSD-SA-19:20.bsnmp.

Update per CR feedback.

Aug 12 2020, 1:31 AM
darrick.freebsd_gmail.com updated the diff for D26037: Add test to verify fix for FreeBSD-SA-19:20.bsnmp.

Update per CR feedback.

Aug 12 2020, 12:32 AM
darrick.freebsd_gmail.com requested review of D26037: Add test to verify fix for FreeBSD-SA-19:20.bsnmp.
Aug 12 2020, 12:18 AM

Jun 23 2020

darrick.freebsd_gmail.com added a comment to D25302: Add `kern.features.witness`.

lgtm

Jun 23 2020, 4:25 PM

Apr 17 2020

darrick.freebsd_gmail.com updated the diff for D24435: Summary: Add kyua test for FreeBSD-SA-19:22:mbuf..

Add #ifdef INVARIRANTS and NULL check.

Apr 17 2020, 11:06 PM
darrick.freebsd_gmail.com added inline comments to D24435: Summary: Add kyua test for FreeBSD-SA-19:22:mbuf..
Apr 17 2020, 1:42 AM

Apr 15 2020

darrick.freebsd_gmail.com updated the test plan for D24435: Summary: Add kyua test for FreeBSD-SA-19:22:mbuf..
Apr 15 2020, 11:54 PM
darrick.freebsd_gmail.com created D24435: Summary: Add kyua test for FreeBSD-SA-19:22:mbuf..
Apr 15 2020, 11:53 PM

Jan 8 2020

darrick.freebsd_gmail.com created D23081: Fix bug in TPM 2.0 TIS driver..
Jan 8 2020, 2:37 AM

Jun 26 2019

darrick.freebsd_gmail.com added a comment to D20764: Allow limiting the size of syslogd output files using options in syslog.conf.

+1 to advise caution on this design. Sounds like you want to roll logs more often.

Jun 26 2019, 8:00 PM

Oct 8 2018

darrick.freebsd_gmail.com updated the diff for D17394: Fix lock order reversal when calling defrouter_remove() from nd6_na_input(). nd6_na_input() can take lle lock before nd6 lock in certain cases..
Oct 8 2018, 9:07 PM
darrick.freebsd_gmail.com updated the diff for D17394: Fix lock order reversal when calling defrouter_remove() from nd6_na_input(). nd6_na_input() can take lle lock before nd6 lock in certain cases..
  • Incorporate CR feedback.
Oct 8 2018, 9:06 PM

Oct 3 2018

darrick.freebsd_gmail.com updated the diff for D16573: Fix code preventing sufficiently small buffers from being malloc buffers..

Remove change to separate fix accidentally introduced.

Oct 3 2018, 8:20 PM
darrick.freebsd_gmail.com created D17394: Fix lock order reversal when calling defrouter_remove() from nd6_na_input(). nd6_na_input() can take lle lock before nd6 lock in certain cases..
Oct 3 2018, 8:19 PM
darrick.freebsd_gmail.com updated the diff for D16573: Fix code preventing sufficiently small buffers from being malloc buffers..
Oct 3 2018, 8:13 PM

Aug 23 2018

darrick.freebsd_gmail.com updated the diff for D16573: Fix code preventing sufficiently small buffers from being malloc buffers..
  • Use patch as suggested by cem instead. Move roundup within vfs_nonvmio_* instead of using check in allocbuf().
Aug 23 2018, 11:18 PM

Aug 17 2018

darrick.freebsd_gmail.com added a comment to D16573: Fix code preventing sufficiently small buffers from being malloc buffers..
In D16573#356822, @kib wrote:

Why did you moved the check for mallocspace back into the want_malloc_buf() ?

Aug 17 2018, 9:14 PM
darrick.freebsd_gmail.com added a comment to D16573: Fix code preventing sufficiently small buffers from being malloc buffers..

Incorporated feedback.

Aug 17 2018, 8:09 PM
darrick.freebsd_gmail.com updated the diff for D16573: Fix code preventing sufficiently small buffers from being malloc buffers..
  • CR feedback.
Aug 17 2018, 8:09 PM
darrick.freebsd_gmail.com added inline comments to D16573: Fix code preventing sufficiently small buffers from being malloc buffers..
Aug 17 2018, 5:34 PM

Aug 16 2018

darrick.freebsd_gmail.com added inline comments to D16573: Fix code preventing sufficiently small buffers from being malloc buffers..
Aug 16 2018, 10:41 PM

Aug 8 2018

darrick.freebsd_gmail.com updated the summary of D16573: Fix code preventing sufficiently small buffers from being malloc buffers..
Aug 8 2018, 8:33 PM
darrick.freebsd_gmail.com added inline comments to D16573: Fix code preventing sufficiently small buffers from being malloc buffers..
Aug 8 2018, 8:31 PM

Aug 7 2018

darrick.freebsd_gmail.com updated the diff for D16573: Fix code preventing sufficiently small buffers from being malloc buffers..
  • CR feedback.
Aug 7 2018, 7:47 PM
darrick.freebsd_gmail.com retitled D16573: Fix code preventing sufficiently small buffers from being malloc buffers. from Remove dead code in vfs_bio.c. to Fix code preventing sufficiently small buffers from being malloc buffers..
Aug 7 2018, 6:14 PM
darrick.freebsd_gmail.com added inline comments to D16573: Fix code preventing sufficiently small buffers from being malloc buffers..
Aug 7 2018, 6:14 PM
darrick.freebsd_gmail.com updated the diff for D16573: Fix code preventing sufficiently small buffers from being malloc buffers..
  • CR feedback.
Aug 7 2018, 6:13 PM
darrick.freebsd_gmail.com updated the diff for D16573: Fix code preventing sufficiently small buffers from being malloc buffers..

Don't round new buffer size up to page size in buffer cache in cases where new buffer would be malloc buffer.

Aug 7 2018, 3:49 AM

Aug 6 2018

darrick.freebsd_gmail.com added a comment to D16573: Fix code preventing sufficiently small buffers from being malloc buffers..
In D16573#352448, @kib wrote:

Hm, I am not sure. I agree that due to the bug, B_MALLOC buffers are never created by the current code. But, do we want to waste that many memory for small non-vmio buffers ? Isn't it better to fix creation of B_MALLOC buffers instead of removing them ? If a filesystem uses 512 or 1024 byte buffers, we do not want to multiply its memory use by a factor of 8 or 4.

It looks simple enough to set B_MALLOC if b_bufsize is zero and newbsize is less than half of the page size.

Aug 6 2018, 6:41 PM

Aug 3 2018

darrick.freebsd_gmail.com updated the diff for D16573: Fix code preventing sufficiently small buffers from being malloc buffers..
  • Fix whitespace.
Aug 3 2018, 10:26 PM
darrick.freebsd_gmail.com updated the diff for D16573: Fix code preventing sufficiently small buffers from being malloc buffers..
  • CR feedback.
Aug 3 2018, 10:08 PM
darrick.freebsd_gmail.com updated the diff for D16573: Fix code preventing sufficiently small buffers from being malloc buffers..
  • CR feedback.
Aug 3 2018, 9:38 PM
darrick.freebsd_gmail.com updated the diff for D16573: Fix code preventing sufficiently small buffers from being malloc buffers..
  • Remove B_MALLOC flag entirely.
Aug 3 2018, 12:12 AM

Aug 2 2018

darrick.freebsd_gmail.com created D16573: Fix code preventing sufficiently small buffers from being malloc buffers..
Aug 2 2018, 10:33 PM

Apr 17 2018

darrick.freebsd_gmail.com added a comment to D15119: Handle overflow of uid or gid in arguments for chown.

lgtm

Apr 17 2018, 8:42 PM · Contributor Reviews (base)
darrick.freebsd_gmail.com added inline comments to D15119: Handle overflow of uid or gid in arguments for chown.
Apr 17 2018, 7:55 PM · Contributor Reviews (base)

Mar 13 2018

darrick.freebsd_gmail.com updated the diff for D14613: Summary: Apply fixes uncovered in vfs_bio.c via static analysis..
  • Incorporate CR feedback.
Mar 13 2018, 10:34 PM
darrick.freebsd_gmail.com added inline comments to D14613: Summary: Apply fixes uncovered in vfs_bio.c via static analysis..
Mar 13 2018, 5:11 PM
darrick.freebsd_gmail.com updated the diff for D14613: Summary: Apply fixes uncovered in vfs_bio.c via static analysis..

Incorporate CR feedback.

Mar 13 2018, 6:18 AM

Mar 8 2018

darrick.freebsd_gmail.com added inline comments to D14613: Summary: Apply fixes uncovered in vfs_bio.c via static analysis..
Mar 8 2018, 7:29 PM
darrick.freebsd_gmail.com added inline comments to D14613: Summary: Apply fixes uncovered in vfs_bio.c via static analysis..
Mar 8 2018, 2:10 AM
darrick.freebsd_gmail.com added inline comments to D14613: Summary: Apply fixes uncovered in vfs_bio.c via static analysis..
Mar 8 2018, 12:52 AM

Mar 7 2018

darrick.freebsd_gmail.com added a reviewer for D14613: Summary: Apply fixes uncovered in vfs_bio.c via static analysis.: bdrewery.
Mar 7 2018, 11:51 PM
darrick.freebsd_gmail.com created D14613: Summary: Apply fixes uncovered in vfs_bio.c via static analysis..
Mar 7 2018, 11:50 PM

Feb 14 2018

darrick.freebsd_gmail.com updated the diff for D14062: Make memory mapped via pmap_qenter() non-executable for amd64/i386..

Fix build break in i386 build.

Feb 14 2018, 2:01 AM

Feb 13 2018

darrick.freebsd_gmail.com retitled D14062: Make memory mapped via pmap_qenter() non-executable for amd64/i386. from Make amd64 kernel stacks non-executable. to Make memory mapped via pmap_qenter() non-executable for amd64/i386..
Feb 13 2018, 10:17 PM
darrick.freebsd_gmail.com updated the diff for D14062: Make memory mapped via pmap_qenter() non-executable for amd64/i386..

Make memory mapped via pmap_qenter() non-executable.

Feb 13 2018, 10:17 PM
darrick.freebsd_gmail.com added a comment to D14062: Make memory mapped via pmap_qenter() non-executable for amd64/i386..

Upon inspection of callers of pmap_qenter, I was unable to find any that required X. Most callers either made a temporary mapping for memcpy, or were allocating objects to be used by the vmem system itself. The only one raised concern was the ELF header load called as part of the exec path. From what I can tell only the elf header is mapped, none of the code within that gets executed. I will resubmit the original diff.

Feb 13 2018, 8:14 PM

Feb 9 2018

darrick.freebsd_gmail.com updated the diff for D14062: Make memory mapped via pmap_qenter() non-executable for amd64/i386..

Per CR feedback localized the changes so that only vm_thread_new() is affected.

Feb 9 2018, 8:08 PM

Jan 26 2018

darrick.freebsd_gmail.com retitled D14062: Make memory mapped via pmap_qenter() non-executable for amd64/i386. from Summary: to Make amd64 kernel stacks non-executable..
Jan 26 2018, 10:06 PM
darrick.freebsd_gmail.com created D14062: Make memory mapped via pmap_qenter() non-executable for amd64/i386..
Jan 26 2018, 10:01 PM