Page MenuHomeFreeBSD

Add test to verify fix for FreeBSD-SA-19:20.bsnmp
ClosedPublic

Authored by darrick.freebsd_gmail.com on Aug 12 2020, 12:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 10, 2:05 AM
Unknown Object (File)
Sat, Aug 8, 7:51 PM
Unknown Object (File)
Sat, Aug 8, 2:38 AM
Unknown Object (File)
Fri, Aug 7, 4:14 PM
Unknown Object (File)
Fri, Aug 7, 1:07 PM
Unknown Object (File)
Thu, Aug 6, 2:15 PM
Unknown Object (File)
Thu, Aug 6, 1:19 PM
Unknown Object (File)
Thu, Aug 6, 8:18 AM
Subscribers

Details

Summary

Verify passing in improper length in asn_buf to asn_get_header() returns ASN_ERR_EOBUF.

Test Plan

Verified test passing with fix for FreeBSD-SA-19:20.bsnmp and failing without.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cem added inline comments.
lib/libbsnmp/tests/bsnmpd_test.c
9 ↗(On Diff #75711)

The explicit length can be dropped to size it correctly automatically, char test_buf[] = { ... };

15 ↗(On Diff #75711)

2, or sizeof(test_buf)

lib/libbsnmp/tests/bsnmpd_test.c
15 ↗(On Diff #75711)

this one was missed?

This revision is now accepted and ready to land.Aug 12 2020, 8:44 PM
This revision was automatically updated to reflect the committed changes.