Page MenuHomeFreeBSD

Add test to verify fix for FreeBSD-SA-19:20.bsnmp
ClosedPublic

Authored by darrick.freebsd_gmail.com on Aug 12 2020, 12:18 AM.

Details

Summary

Verify passing in improper length in asn_buf to asn_get_header() returns ASN_ERR_EOBUF.

Test Plan

Verified test passing with fix for FreeBSD-SA-19:20.bsnmp and failing without.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cem added inline comments.
lib/libbsnmp/tests/bsnmpd_test.c
9 ↗(On Diff #75711)

The explicit length can be dropped to size it correctly automatically, char test_buf[] = { ... };

15 ↗(On Diff #75711)

2, or sizeof(test_buf)

lib/libbsnmp/tests/bsnmpd_test.c
15 ↗(On Diff #75711)

this one was missed?

This revision is now accepted and ready to land.Aug 12 2020, 8:44 PM
This revision was automatically updated to reflect the committed changes.