Page MenuHomeFreeBSD

Add test to verify fix for FreeBSD-SA-19:20.bsnmp
ClosedPublic

Authored by darrick.freebsd_gmail.com on Aug 12 2020, 12:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 7, 9:04 AM
Unknown Object (File)
Sat, Mar 7, 3:14 AM
Unknown Object (File)
Fri, Mar 6, 2:53 PM
Unknown Object (File)
Wed, Mar 4, 3:05 AM
Unknown Object (File)
Tue, Mar 3, 4:10 PM
Unknown Object (File)
Tue, Mar 3, 10:20 AM
Unknown Object (File)
Sat, Feb 28, 5:16 PM
Unknown Object (File)
Tue, Feb 24, 1:25 AM
Subscribers

Details

Summary

Verify passing in improper length in asn_buf to asn_get_header() returns ASN_ERR_EOBUF.

Test Plan

Verified test passing with fix for FreeBSD-SA-19:20.bsnmp and failing without.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cem added inline comments.
lib/libbsnmp/tests/bsnmpd_test.c
9 ↗(On Diff #75711)

The explicit length can be dropped to size it correctly automatically, char test_buf[] = { ... };

15 ↗(On Diff #75711)

2, or sizeof(test_buf)

lib/libbsnmp/tests/bsnmpd_test.c
15 ↗(On Diff #75711)

this one was missed?

This revision is now accepted and ready to land.Aug 12 2020, 8:44 PM
This revision was automatically updated to reflect the committed changes.