Page MenuHomeFreeBSD

Add test to verify fix for FreeBSD-SA-19:20.bsnmp
ClosedPublic

Authored by darrick.freebsd_gmail.com on Aug 12 2020, 12:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 16, 11:37 AM
Unknown Object (File)
Thu, Oct 16, 11:37 AM
Unknown Object (File)
Wed, Oct 15, 11:56 PM
Unknown Object (File)
Wed, Oct 15, 11:56 PM
Unknown Object (File)
Wed, Oct 15, 11:55 PM
Unknown Object (File)
Wed, Oct 15, 11:55 PM
Unknown Object (File)
Wed, Oct 15, 1:26 PM
Unknown Object (File)
Tue, Oct 14, 3:21 AM
Subscribers

Details

Summary

Verify passing in improper length in asn_buf to asn_get_header() returns ASN_ERR_EOBUF.

Test Plan

Verified test passing with fix for FreeBSD-SA-19:20.bsnmp and failing without.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32936
Build 30334: arc lint + arc unit

Event Timeline

cem added inline comments.
lib/libbsnmp/tests/bsnmpd_test.c
10

The explicit length can be dropped to size it correctly automatically, char test_buf[] = { ... };

16

2, or sizeof(test_buf)

lib/libbsnmp/tests/bsnmpd_test.c
16

this one was missed?

This revision is now accepted and ready to land.Aug 12 2020, 8:44 PM
This revision was automatically updated to reflect the committed changes.