Differential D26026

Fix libdtrace build with zsh as /bin/sh
ClosedPublic
Actions

Authored by arichardson on Aug 11 2020, 3:44 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Mar 28, 5:01 PM

	Unknown Object (File)
	Jan 5 2024, 4:43 PM

	Unknown Object (File)
	Nov 11 2023, 2:10 PM

	Unknown Object (File)
	Nov 9 2023, 8:36 PM

	Unknown Object (File)
	Nov 1 2023, 1:47 PM

	Unknown Object (File)
	Oct 10 2023, 1:06 PM

	Unknown Object (File)
	Oct 8 2023, 7:27 PM

	Unknown Object (File)
	Sep 30 2023, 1:50 PM

View All 39 Files

Subscribers

Details

Reviewers

markj
emaste
brooks
gnn

Commits

rS364124: Fix libdtrace build with zsh as /bin/sh

Summary

When zsh runs in POSIX sh mode it does not support the -e flag to echo.
Use printf instead of echo to avoid the "-e" characters being printed.

Obtained from: CheriBSD

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Aug 11 2020, 3:44 PM

Harbormaster completed remote builds in B32914: Diff 75679.Aug 11 2020, 3:44 PM

arichardson requested review of this revision.Aug 11 2020, 3:44 PM

arichardson retitled this revision from [UPSTREAM] Fix libdtrace build with zsh as /bin/sh to Fix libdtrace build with zsh as /bin/sh.Aug 11 2020, 3:45 PM

markj added inline comments.Aug 11 2020, 3:47 PM

cddl/contrib/opensolaris/lib/libdtrace/common/mkerrno.sh
37 ↗	(On Diff #75679)	We can actually just drop the pragma ident. That's an old Solaris thing. Upstream (illumos) removes them whenever they modify files. The line following the copyright can be deleted as well. Ditto for the other files below.

drop pragma ident

Harbormaster completed remote builds in B32916: Diff 75682.Aug 11 2020, 3:50 PM

markj accepted this revision.Aug 11 2020, 4:07 PM

This revision is now accepted and ready to land.Aug 11 2020, 4:07 PM

Closed by commit rS364124: Fix libdtrace build with zsh as /bin/sh (authored by arichardson). · Explain WhyAug 11 2020, 4:47 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS364124: Fix libdtrace build with zsh as /bin/sh.

Herald added a reviewer: gnn. · View Herald TranscriptAug 11 2020, 4:47 PM

Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

head/

cddl/

contrib/

opensolaris/

lib/

libdtrace/

common/

15 lines

33 lines

37 lines

15 lines

Diff 75687

head/cddl/contrib/opensolaris/lib/libdtrace/common/mkerrno.sh

Loading...

head/cddl/contrib/opensolaris/lib/libdtrace/common/mkerrtags.sh

Loading...

head/cddl/contrib/opensolaris/lib/libdtrace/common/mknames.sh

Loading...

head/cddl/contrib/opensolaris/lib/libdtrace/common/mksignal.sh

Loading...