Page MenuHomeFreeBSD
Differential D26026

Fix libdtrace build with zsh as /bin/sh
ClosedPublic
Actions

Authored by arichardson on Aug 11 2020, 3:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 2:40 AM
Unknown Object (File)
Nov 19 2024, 8:33 PM
Unknown Object (File)
Nov 7 2024, 8:27 PM
Unknown Object (File)
Oct 29 2024, 7:09 AM
Unknown Object (File)
Oct 22 2024, 2:13 PM
Unknown Object (File)
Oct 22 2024, 7:13 AM
Unknown Object (File)
Oct 22 2024, 4:55 AM
Unknown Object (File)
Oct 21 2024, 8:56 PM
View All 74 Files
Subscribers
imp

Details

Reviewers
markj
emaste
brooks
gnn
Commits
rS364124: Fix libdtrace build with zsh as /bin/sh
Summary

When zsh runs in POSIX sh mode it does not support the -e flag to echo.
Use printf instead of echo to avoid the "-e" characters being printed.

Obtained from: CheriBSD

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 32916
Build 30314: arc lint + arc unit

Event Timeline

arichardson created this revision.Aug 11 2020, 3:44 PM
Harbormaster completed remote builds in B32914: Diff 75679.Aug 11 2020, 3:44 PM
arichardson requested review of this revision.Aug 11 2020, 3:44 PM
arichardson retitled this revision from [UPSTREAM] Fix libdtrace build with zsh as /bin/sh to Fix libdtrace build with zsh as /bin/sh.Aug 11 2020, 3:45 PM
markj added inline comments.Aug 11 2020, 3:47 PM
cddl/contrib/opensolaris/lib/libdtrace/common/mkerrno.sh
36

We can actually just drop the pragma ident. That's an old Solaris thing. Upstream (illumos) removes them whenever they modify files. The line following the copyright can be deleted as well. Ditto for the other files below.

arichardson updated this revision to Diff 75682.Aug 11 2020, 3:50 PM

drop pragma ident

Harbormaster completed remote builds in B32916: Diff 75682.Aug 11 2020, 3:50 PM
markj accepted this revision.Aug 11 2020, 4:07 PM
This revision is now accepted and ready to land.Aug 11 2020, 4:07 PM
Closed by commit rS364124: Fix libdtrace build with zsh as /bin/sh (authored by arichardson). · Explain WhyAug 11 2020, 4:47 PM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rS364124: Fix libdtrace build with zsh as /bin/sh.
Herald added a reviewer: gnn. · View Herald TranscriptAug 11 2020, 4:47 PM
Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

PathSize
cddl/
contrib/
opensolaris/
lib/
libdtrace/
common/
15 lines
33 lines
37 lines
15 lines

Diff 75682

View Options

cddl/contrib/opensolaris/lib/libdtrace/common/mkerrno.sh

Loading...
View Options

cddl/contrib/opensolaris/lib/libdtrace/common/mkerrtags.sh

Loading...
View Options

cddl/contrib/opensolaris/lib/libdtrace/common/mknames.sh

Loading...
View Options

cddl/contrib/opensolaris/lib/libdtrace/common/mksignal.sh

Loading...