gctl_get_geom: Skip validation of g_class.
ClosedPublic
Actions

Authored by delphij on Jul 26 2020, 6:03 AM.

Details

Reviewers

phk
pjd
mav
cem

Commits

rS363585: gctl_get_geom: Skip validation of g_class.

Summary

The caller from kernel is expected to provide an valid g_class
pointer, instead of traversing the global g_class list, just
assert that it is not NULL and use it directly instead.

MFC after: 2 weeks

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32550
Build 30022: arc lint + arc unit

Event Timeline

delphij requested review of this revision.Jul 26 2020, 6:03 AM

delphij created this revision.

Harbormaster completed remote builds in B32550: Diff 74943.Jul 26 2020, 6:03 AM

Makes sense. Not sure why it was made so paranoid.

This revision is now accepted and ready to land.Jul 26 2020, 7:45 PM

It was primarily made paranoid because GEOM went into the kernel during a very turbulent period in terms of locking, and because some of the compatibility shims necessary to keep systems working were ... "interesting".

Closed by commit rS363585: gctl_get_geom: Skip validation of g_class. (authored by delphij). · Explain WhyJul 26 2020, 10:31 PM

This revision was automatically updated to reflect the committed changes.

delphij added a commit: rS363585: gctl_get_geom: Skip validation of g_class..

Herald added a subscriber: imp. · View Herald TranscriptJul 26 2020, 10:31 PM