Page MenuHomeFreeBSD
Differential D25739

Consistently use gctl_get_provider instead of home-grown variants.
ClosedPublic
Actions

Authored by delphij on Jul 20 2020, 12:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 11, 5:41 PM
Unknown Object (File)
Thu, Sep 10, 9:16 PM
Unknown Object (File)
Sun, Sep 6, 4:27 PM
Unknown Object (File)
Sat, Sep 5, 5:04 PM
Unknown Object (File)
Sat, Sep 5, 4:07 PM
Unknown Object (File)
Sat, Sep 5, 11:00 AM
Unknown Object (File)
Sat, Sep 5, 5:34 AM
Unknown Object (File)
Fri, Sep 4, 11:05 PM
View All Files
Subscribers
markmi_dsl-only.net

Details

Reviewers
mav
pjd
cem
emaste
imp
Commits
rS363411: Consistently use gctl_get_provider instead of home-grown variants.
Summary

Consistently use gctl_get_provider instead of home-grown variants.

Test Plan

test the 

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32428
Build 29905: arc lint + arc unit

Event Timeline

delphij requested review of this revision.Jul 20 2020, 12:20 AM
delphij created this revision.
Harbormaster completed remote builds in B32426: Diff 74678.Jul 20 2020, 12:20 AM
delphij added a parent revision: D25738: gctl_get_class, gctl_get_geom and gctl_get_provider: provide feedback when the requested argument is missing..Jul 20 2020, 12:20 AM
delphij updated this revision to Diff 74679.Jul 20 2020, 12:40 AM

Eliminate some unrelated changes to make this smaller.

Harbormaster completed remote builds in B32427: Diff 74679.Jul 20 2020, 12:40 AM
delphij updated this revision to Diff 74680.Jul 20 2020, 12:41 AM

Separate from D25738.

Harbormaster completed remote builds in B32428: Diff 74680.Jul 20 2020, 12:41 AM
cem accepted this revision.Jul 22 2020, 12:26 AM
This revision is now accepted and ready to land.Jul 22 2020, 12:26 AM
imp accepted this revision.Jul 22 2020, 1:16 AM
Closed by commit rS363411: Consistently use gctl_get_provider instead of home-grown variants. (authored by delphij). · Explain WhyJul 22 2020, 2:15 AM
This revision was automatically updated to reflect the committed changes.
delphij added a commit: rS363411: Consistently use gctl_get_provider instead of home-grown variants..
markmi_dsl-only.net added a subscriber: markmi_dsl-only.net.Mar 15 2022, 10:38 PM

FYI: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262554#c9 indicates that a home-grown variant is still in use in sys/geom/part/g_part.c . It disallowed /dev/ prefix usage in a gpart add for what that submittal was reporting.

Revision Contents
Changeset List

PathSize
sys/
geom/
cache/
14 lines
concat/
28 lines
eli/
29 lines
label/
14 lines
mirror/
56 lines
mountver/
15 lines
nop/
48 lines
raid3/
15 lines
stripe/
26 lines
virstor/
19 lines

Diff 74680

View Options

sys/geom/cache/g_cache.c

Loading...
View Options

sys/geom/concat/g_concat.c

Loading...
View Options

sys/geom/eli/g_eli_ctl.c

Loading...
View Options

sys/geom/label/g_label.c

Loading...
View Options

sys/geom/mirror/g_mirror_ctl.c

Loading...
View Options

sys/geom/mountver/g_mountver.c

Loading...
View Options

sys/geom/nop/g_nop.c

Loading...
View Options

sys/geom/raid3/g_raid3_ctl.c

Loading...
View Options

sys/geom/stripe/g_stripe.c

Loading...
View Options

sys/geom/virstor/g_virstor.c

Loading...