Paths

Table of Contentst

Differential D25627

nscd: Warn when invalid configuration options are selected
ClosedPublic
Actions

Authored by allanjude on Jul 11 2020, 6:53 PM.

Tags

None

Referenced Files

	F157076908: D25627.id74333.diff
	Mon, May 18, 7:30 AM

	F157014658: D25627.id74329.diff
	Sun, May 17, 11:18 PM

	F157013223: D25627.id74329.diff
	Sun, May 17, 11:09 PM

	Unknown Object (File)
	Sun, May 17, 9:10 AM

	Unknown Object (File)
	Sun, May 17, 9:06 AM

	Unknown Object (File)
	Sat, May 16, 2:44 PM

	Unknown Object (File)
	Mon, May 11, 11:59 AM

	Unknown Object (File)
	Mon, May 11, 2:25 AM

Subscribers

Details

Reviewers

markj
feld
thj
freqlabs

Commits

rS363109: nscd: does not warn about invalid values what parsing config file

Summary

This is a rebase of the patch from amutu@amutu.com in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202135

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32257
Build 29747: arc lint + arc unit

Event Timeline

allanjude created this revision.Jul 11 2020, 6:53 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 11 2020, 6:53 PM

allanjude requested review of this revision.Jul 11 2020, 6:53 PM

Harbormaster completed remote builds in B32256: Diff 74328.Jul 11 2020, 6:53 PM

allanjude edited the summary of this revision. (Show Details)Jul 11 2020, 6:53 PM

Fix for keep-hot-count

Harbormaster completed remote builds in B32257: Diff 74329.Jul 11 2020, 6:54 PM

markj accepted this revision.Jul 11 2020, 6:57 PM

markj added inline comments.

usr.sbin/nscd/parser.c
538–547	It is a bit weird to test what is effectively a bool using `> 0`. `!= 0` would be clearer, or just write `if (invalid_value) {`.
539	Missing a space for the continuing line.

This revision is now accepted and ready to land.Jul 11 2020, 6:57 PM

Agreed, I would have used a bool rather than an int, but this is an improvement regardless.

allanjude marked 2 inline comments as done.Jul 11 2020, 7:40 PM

allanjude added inline comments.

usr.sbin/nscd/parser.c
538–547	right.
539	This is not actually a continuing line, LOG_ERR_2() is a macro that turns into syslog(LOG_ERR, "nscd error (from %s): %s", sender, ferror); where the first line is 'sender' and the 2nd line is 'ferror'. Only the 2nd parameter has printf expansion.

Address review feedback

This revision now requires review to proceed.Jul 11 2020, 7:41 PM

Harbormaster completed remote builds in B32259: Diff 74332.Jul 11 2020, 7:41 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 11 2020, 7:44 PM

Closed by commit rS363109: nscd: does not warn about invalid values what parsing config file (authored by allanjude). · Explain Why

This revision was automatically updated to reflect the committed changes.

allanjude added a commit: rS363109: nscd: does not warn about invalid values what parsing config file.

Revision Contents
Changeset List

Path

Size

usr.sbin/

nscd/

39 lines

Diff 74329

usr.sbin/nscd/parser.c

Loading...