Details

Reviewers

melifaro
ae

Commits

rS363403: Transition from rtrequest1_fib() to rib_action().
rS363319: Transition from rtrequest1_fib() to rib_action().

Summary

Remove all variations of rtrequest <rtrequest1_fib, rtrequest_fib, in6_rtrequest, rtrequest_fib> and their uses, and switch to rib_action(). This is part of the new routing KPI.

Submitted by: Neel Chauhan <neel AT neelc DOT org>
Suggested by: melifaro

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

nc created this revision.Jul 2 2020, 4:42 AM

Herald added subscribers: bz, imp. · View Herald TranscriptJul 2 2020, 4:43 AM

nc requested review of this revision.Jul 2 2020, 4:43 AM

This patch currently panics and needs revision

Well, fixed the panics (which happened on BOOT on the first patch).

nc added subscribers: melifaro, ae.Jul 7 2020, 4:19 AM

Remove all variations of rtrequest (rtrequest1_fib, rtrequest_fib, in6_rtrequest, rtrequest_fib) as well.

nc updated this revision to Diff 74557.Jul 17 2020, 4:45 AM

nc updated this revision to Diff 74558.Jul 17 2020, 4:49 AM

donner added a subscriber: donner.Jul 17 2020, 7:54 AM

donner added inline comments.

sys/fs/nfsclient/nfs_clvfsops.c
470 ↗	(On Diff #74558)	info is not initialized here. I'd recommend to do a in-place initialization here (violating style(9)) for the statically defined field .rti_flags, which implicitly zeroes all other fields. https://en.cppreference.com/w/c/language/struct_initialization
473–476 ↗	(On Diff #74558)	To explain the comment above about struct initialization here. struct sockaddr_in mask = {}; struct sockaddr_in sin = { .sin_family = AF_INET, .sin_len = sizeof(sin) };
sys/netinet6/nd6_rtr.c
677 ↗	(On Diff #74558)	dito
2047 ↗	(On Diff #74558)	dito
2177 ↗	(On Diff #74558)	dito

Made some suggested revisions.

nc marked 5 inline comments as done.Jul 17 2020, 8:29 PM

nc added inline comments.

sys/fs/nfsclient/nfs_clvfsops.c
470 ↗	(On Diff #74558)	However, we use things like `info.rti_info[RTAX_DST]` which I'm not sure if it can be statically assigned.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 19 2020, 9:29 AM

Closed by commit rS363319: Transition from rtrequest1_fib() to rib_action(). (authored by melifaro). · Explain Why

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rS363319: Transition from rtrequest1_fib() to rib_action()..

melifaro added a commit: rS363403: Transition from rtrequest1_fib() to rib_action()..Jul 21 2020, 7:56 PM

Transition from rtrequest1_fib() to rib_action()
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 74012

sys/net/if.c

sys/net/route.h

sys/net/route.c

sys/netinet6/nd6.c

Transition from rtrequest1_fib() to rib_action()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 74012

sys/net/if.c

sys/net/route.h

sys/net/route.c

sys/netinet6/nd6.c

Transition from rtrequest1_fib() to rib_action()
ClosedPublic
Actions

Revision Contents
Changeset List