Page MenuHomeFreeBSD

Improve error path in BBR
ClosedPublic

Authored by tuexen on Jun 27 2020, 1:56 PM.
Tags
None
Referenced Files
F125480897: D25486.diff
Fri, Aug 8, 6:11 AM
F125455539: D25486.id73760.diff
Fri, Aug 8, 12:09 AM
Unknown Object (File)
Tue, Jul 22, 2:25 PM
Unknown Object (File)
Tue, Jul 22, 2:25 PM
Unknown Object (File)
Tue, Jul 22, 2:25 PM
Unknown Object (File)
Tue, Jul 22, 2:25 PM
Unknown Object (File)
Jun 29 2025, 4:42 AM
Unknown Object (File)
Jun 17 2025, 6:14 AM
Subscribers

Details

Summary

syzkaller found a bug in the BBR code. On an error path, the socket buffer was not unlocked. Free also on this path the allocated mbuf.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 32009

Event Timeline

This mechanical change looks good to me. Just wondering is similar missing sbunlock would be in RACK or elsewhere in BBR. (but didn't spot anything obvious just now)

This revision is now accepted and ready to land.Jun 27 2020, 3:04 PM

This mechanical change looks good to me. Just wondering is similar missing sbunlock would be in RACK or elsewhere in BBR. (but didn't spot anything obvious just now)

syzkaller triggered the condition. I looked for other cases, but did not spot any. That doesn't mean that they don't exist... Maybe syzkaller will find other issue, I don't know. That is the reason why it it constantly running...