Differential D25486

Improve error path in BBR
ClosedPublic
Actions

Authored by tuexen on Jun 27 2020, 1:56 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 17, 10:12 AM

	Unknown Object (File)
	Jan 2 2024, 7:11 PM

	Unknown Object (File)
	Dec 20 2023, 8:01 AM

	Unknown Object (File)
	Sep 12 2023, 7:10 PM

	Unknown Object (File)
	Sep 7 2023, 2:31 PM

	Unknown Object (File)
	Sep 7 2023, 2:31 PM

	Unknown Object (File)
	Sep 7 2023, 2:30 PM

	Unknown Object (File)
	Sep 3 2023, 5:34 PM

View All 14 Files

Subscribers

Details

Reviewers

rrs
rscheff

Group Reviewers

Commits

rS362846: Fix the cleanup handling in a error path for TCP BBR.

Summary

syzkaller found a bug in the BBR code. On an error path, the socket buffer was not unlocked. Free also on this path the allocated mbuf.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Jun 27 2020, 1:56 PM

Herald added a reviewer: transport. · View Herald TranscriptJun 27 2020, 1:56 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Jun 27 2020, 1:56 PM

Harbormaster completed remote builds in B32009: Diff 73760.Jun 27 2020, 1:57 PM

tuexen edited the summary of this revision. (Show Details)Jun 27 2020, 1:57 PM

This mechanical change looks good to me. Just wondering is similar missing sbunlock would be in RACK or elsewhere in BBR. (but didn't spot anything obvious just now)

This revision is now accepted and ready to land.Jun 27 2020, 3:04 PM

In D25486#562860, @rscheff wrote:

This mechanical change looks good to me. Just wondering is similar missing sbunlock would be in RACK or elsewhere in BBR. (but didn't spot anything obvious just now)

syzkaller triggered the condition. I looked for other cases, but did not spot any. That doesn't mean that they don't exist... Maybe syzkaller will find other issue, I don't know. That is the reason why it it constantly running...

Closed by commit rS362846: Fix the cleanup handling in a error path for TCP BBR. (authored by tuexen). · Explain WhyJul 1 2020, 5:17 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rS362846: Fix the cleanup handling in a error path for TCP BBR..

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

tcp_stacks/

2 lines

Diff 73977

head/sys/netinet/tcp_stacks/bbr.c

Loading...