Page MenuHomeFreeBSD
Differential D25200

New Code of Conduct (LLVM-derived)
ClosedPublic
Actions

Authored by bcr on Jun 9 2020, 7:26 PM.
Tags
None
Referenced Files
F106227119: D25200.diff
Fri, Dec 27, 12:54 PM
Unknown Object (File)
Wed, Dec 25, 7:59 PM
Unknown Object (File)
Nov 21 2024, 10:15 PM
Unknown Object (File)
Nov 5 2024, 3:54 PM
Unknown Object (File)
Oct 17 2024, 8:36 AM
Unknown Object (File)
Oct 1 2024, 3:14 PM
Unknown Object (File)
Sep 29 2024, 11:58 PM
Unknown Object (File)
Sep 23 2024, 4:40 PM
View All 59 Files
Subscribers
allanjude
brooks
imp
jhb

Details

Reviewers
seanc
imp
allanjude
jhb
jrm
jeff
brooks
Group Reviewers
Core Team
Commits
rD54229: Per FreeBSD developer consensus (overwhelming majority), adopt an LLVM-derived
Summary

A rendered version can be found here: https://people.freebsd.org/~bcr/internal/code-of-conduct.html

Test Plan
  1. Apply diff to a doc tree checkout
  2. run:
env DOCDIR=/tmp/www make ENGLISH_ONLY=yes WEB_ONLY=yes all install

in ~/doc/en_US.ISO8859-1/htdocs/

  1. review resulting internal/code-of-conduct.html

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bcr requested review of this revision.Jun 9 2020, 7:26 PM
bcr created this revision.
bcr created this object with visibility "Core Team (Project)".
bcr created this object with edit policy "Core Team (Project)".
Harbormaster completed remote builds in B31595: Diff 72877.Jun 9 2020, 7:26 PM
bcr edited the test plan for this revision. (Show Details)Jun 9 2020, 7:27 PM
seanc accepted this revision.Jun 9 2020, 7:28 PM
This revision is now accepted and ready to land.Jun 9 2020, 7:28 PM
imp accepted this revision.Jun 9 2020, 7:28 PM
imp added a subscriber: imp.
imp added inline comments.
en_US.ISO8859-1/htdocs/internal/code-of-conduct.xml
56–62

looks good to me.

jhb added a subscriber: jhb.Jun 9 2020, 7:31 PM
jhb added inline comments.
en_US.ISO8859-1/htdocs/internal/code-of-conduct.xml
58

Do we want to use 'FreeBSD.org' here and elsewhere? I think it is more consistent with other pages on our website?

60

I think the href should just be "conduct-reporting.html" as it was in the old version (relative URL rather than absolute)

allanjude requested changes to this revision.Jun 9 2020, 7:31 PM
allanjude added a subscriber: allanjude.
allanjude added inline comments.
en_US.ISO8859-1/htdocs/internal/code-of-conduct.xml
138

There is an excess quote mark here

This revision now requires changes to proceed.Jun 9 2020, 7:31 PM
bcr updated this revision to Diff 72878.Jun 9 2020, 7:37 PM

Minor updates (remove excess " in one email link and fix indentation).

allanjude accepted this revision as: allanjude.Jun 9 2020, 7:41 PM
imp added inline comments.Jun 9 2020, 7:42 PM
en_US.ISO8859-1/htdocs/internal/code-of-conduct.xml
58

Didn't notice that...

60

also dodges the question of whether this should be FreeBSD.org or not. Plus will work on our mirrors w/o transferring back to the mother ship...

imp accepted this revision.Jun 9 2020, 7:43 PM

The only thing that we need to do is the relative vs absolute link. The FreeBSD.org thing would be nice as well, but not urgent.

en_US.ISO8859-1/htdocs/internal/code-of-conduct.xml
140

FreeBSD.org here too, if we do it

This revision is now accepted and ready to land.Jun 9 2020, 7:43 PM
bcr updated this revision to Diff 72880.Jun 9 2020, 7:47 PM

Uppercase FreeBSD again (sorry Sean, it's more consistent with the rest of our web docs) and shorten the link to the reporting guidelines.

This revision now requires review to proceed.Jun 9 2020, 7:47 PM
jhb added a comment.Jun 9 2020, 7:47 PM

I think the lowercase is fine since it is consistent. The relative link we should still fix.

jhb accepted this revision.Jun 9 2020, 7:48 PM
This revision is now accepted and ready to land.Jun 9 2020, 7:48 PM
seanc accepted this revision.Jun 9 2020, 7:50 PM

I just find the mixed-case thing personally amusing, nothing else. As long as it's consistent, I'm fine with it. Let's ship this!

bcr updated this revision to Diff 72881.Jun 9 2020, 7:54 PM
bcr added a reviewer: jrm.

Bolded the "In general, ..." bullet point for consistency.

This revision now requires review to proceed.Jun 9 2020, 7:54 PM
brooks added a subscriber: brooks.Jun 9 2020, 7:56 PM
brooks added inline comments.
en_US.ISO8859-1/htdocs/internal/code-of-conduct.xml
147

This is a dead link, let's just mention them but don't include the link. Archive.org hasn't visited the page since 2014.

jhb accepted this revision.Jun 9 2020, 7:56 PM
This revision is now accepted and ready to land.Jun 9 2020, 7:56 PM
bcr updated this revision to Diff 72884.Jun 9 2020, 7:59 PM

Remove link to the Speak Up! project as it seems to be dead.

This revision now requires review to proceed.Jun 9 2020, 7:59 PM
jeff accepted this revision.Jun 9 2020, 7:59 PM
This revision is now accepted and ready to land.Jun 9 2020, 7:59 PM
seanc added a comment.Jun 9 2020, 7:59 PM
This comment was removed by seanc.
seanc accepted this revision.Jun 9 2020, 8:00 PM

:shipit:

brooks accepted this revision.Jun 9 2020, 8:04 PM
Closed by commit rD54229: Per FreeBSD developer consensus (overwhelming majority), adopt an LLVM-derived (authored by bcr). · Explain WhyJun 9 2020, 8:04 PM
This revision was automatically updated to reflect the committed changes.
bcr added a commit: rD54229: Per FreeBSD developer consensus (overwhelming majority), adopt an LLVM-derived.
bcr changed the visibility from "Core Team (Project)" to "Public (No Login Required)".Jun 9 2020, 8:24 PM
bcr changed the edit policy from "Core Team (Project)" to "No One".

Revision Contents
Changeset List

PathSize
en_US.ISO8859-1/
htdocs/
internal/
208 lines

Diff 72878

View Options

en_US.ISO8859-1/htdocs/internal/code-of-conduct.xml

Loading...