Differential D25155
CISS: Support >48 JBOD drives, fix SES enumeration, no panic on unplug, sysctl tunables &more verbosity... Authored by pen_lysator.liu.se on Jun 5 2020, 6:42 PM. Tags None Referenced Files
Subscribers
Details
This patch fixes the handling of many drives in JBOD (HBA) mode Also fixes the panic when removing and replugging devices while active. And adds visible sysctl's for tunables. Tested the patch with HP H241 SmartHBA cards and two HP D6020 external
Diff Detail
Event TimelineThere are a very large number of changes, so older changes are hidden. Show Older Changes Comment Actions I am not very close to ciss, only fixed couple issues there, but it looks OK to me, except the initiator_id comment and somewhat weird way to detect max target number.
Comment Actions Adds a fix to allow SES to detect stuff behind the CISS controllers and more verbosity Comment Actions Regarding testing the patch - I'll try to find some more/other models of HP RAID controllers and verify the functionality with them. There should be people out there using HP controllers already on smaller machines so I can try to find some people using HP RAID cards to test it too... Added a fix for another problem that prevents SES ("sesutil map" for example) to get information about what is connected behind CISS controllers in the latest update. Comment Actions I have rebased patch against the recent HEAD, compiled, installed and rebooted. The hardware for test was Hp Proliant Dl360 G7 with Unfortunately, the system wasn't able to mount / from ZFS, it was stuck looping: Comment Actions So opcode 0x1a is 'MODE SENSE(6)' which should generally work... but these messages are saying that the target didn't report status. Comment Actions I have a while to take another look into this promising patch and found out that the culprit of not mounting the root filesystem was the setting: hw.ciss.expose_hidden_physical=1 in loader.conf, which really did nothing before* the patch but also was harmless. After removing this line from loader.conf I booted successfully in normal and verbose mode. Since I am not able to update the review, I paste links to the patch. I skipped changes in lines 1287-1289 and had to change a bit 2345-2346 to rebase on the recent main.
Comment Actions I tried to get rid of problem with hidden devices and applied the change suggested by kaktus. Updated diff works for me. https://zarychtam.pb.pwste.edu.pl/diffs/D25155_rebased_full.diff
Comment Actions fetch: https://zarychtam.pb.pwste.edu.pl/diffs/D25155_rebased_full.diff: Operation timed out Any chance you can send me this via email? imp@freebsd.org Comment Actions The link was temporarily disabled due to problems with the Apache where I was testing things related to another PR 268318. It should work now. I am sorry for the inconvenience.
Comment Actions The rebased patch applies clearly on stable/13, there were also no problems running patched stable/13. I hope it will make it into the head before stable/14 is branched. Whilst additional ciss(4) verbosity could be helpful, fixing the enumeration problem for a larger number of disks is critical. Comment Actions I am still testing this solution 24/7. So far I had no issues. Comment Actions I am sorry, the situation with this hosting is dynamic. Please try this one, it applies clearly: Comment Actions I will keep you updated. It still applies, builds and runs fine on CURRENT and stable/14. The patch in the link below is rebased against recent CURRENT | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Should the device ID be 0xa821144d?