Page MenuHomeFreeBSD

Fix PCI bus detach to delete child devices.
ClosedPublic

Authored by jhb on Apr 20 2016, 2:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 3, 7:48 AM
Unknown Object (File)
Mon, Aug 3, 5:49 AM
Unknown Object (File)
Sun, Aug 2, 1:08 AM
Unknown Object (File)
Sat, Aug 1, 3:42 AM
Unknown Object (File)
Sun, Jul 26, 2:34 PM
Unknown Object (File)
Tue, Jul 21, 6:23 PM
Unknown Object (File)
Sun, Jul 12, 5:12 PM
Unknown Object (File)
May 19 2026, 10:25 PM
Subscribers

Details

Summary

Fix PCI bus detach to delete child devices.

Arguably, bus_generic_detach() should be calling device_delete_children()
as most (if not all) buses should delete child devices when detaching,
but that's a larger problem to solve.

If I had my druthers I'd probably rename bus_generic_detach() to
device_detach_children() and change bus_generic_detach() to call
device_detach_children() followed by device_delete_children().

Test Plan
  • the hotplug patches detach (and delete) the PCI bus on card insertion and exercised this change

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable