Page MenuHomeFreeBSD

Fix PCI bus detach to delete child devices.
ClosedPublic

Authored by jhb on Apr 20 2016, 2:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 19, 10:25 PM
Unknown Object (File)
Tue, May 19, 6:04 PM
Unknown Object (File)
Tue, May 19, 12:32 PM
Unknown Object (File)
Tue, May 19, 9:13 AM
Unknown Object (File)
Tue, May 19, 2:21 AM
Unknown Object (File)
Mon, May 18, 10:58 AM
Unknown Object (File)
Sun, May 17, 10:28 AM
Unknown Object (File)
Sat, May 16, 2:04 AM
Subscribers

Details

Summary

Fix PCI bus detach to delete child devices.

Arguably, bus_generic_detach() should be calling device_delete_children()
as most (if not all) buses should delete child devices when detaching,
but that's a larger problem to solve.

If I had my druthers I'd probably rename bus_generic_detach() to
device_detach_children() and change bus_generic_detach() to call
device_detach_children() followed by device_delete_children().

Test Plan
  • the hotplug patches detach (and delete) the PCI bus on card insertion and exercised this change

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable