Remove f_label from struct file
ClosedPublic
Actions

Authored by mjg on May 28 2020, 11:19 AM.

Tags

None

Referenced Files

	F169257841: D25036.id.diff
	Tue, Sep 1, 2:05 AM

	F169248691: D25036.diff
	Tue, Sep 1, 1:33 AM

	Unknown Object (File)
	Mon, Aug 31, 3:35 AM

	Unknown Object (File)
	Sun, Aug 30, 12:08 AM

	Unknown Object (File)
	Sat, Aug 29, 10:55 PM

	Unknown Object (File)
	Fri, Aug 21, 3:04 PM

	Unknown Object (File)
	Fri, Aug 21, 3:04 PM

	Unknown Object (File)
	Fri, Aug 21, 3:04 PM

View All Files

Subscribers

imp

Details

Reviewers

kib
rwatson

Commits

rS361695: Remove ->f_label from struct file

Summary

The field was added in r141137 in 2005 and is unused (I did not check if something was using it at any point).

It avoidably grows a struct which is NOFREE and easily gets hundreds of thousands of instances.

Removing the field also allows D25024 at no extra size cost.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mjg created this revision.May 28 2020, 11:19 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 28 2020, 11:19 AM

Harbormaster completed remote builds in B31346: Diff 72362.May 28 2020, 11:19 AM

mjg requested review of this revision.May 28 2020, 11:19 AM

mjg edited the summary of this revision. (Show Details)

kib accepted this revision.May 28 2020, 4:37 PM

This revision is now accepted and ready to land.May 28 2020, 4:37 PM

Closed by commit rS361695: Remove ->f_label from struct file (authored by mjg). · Explain WhyJun 1 2020, 3:58 PM

This revision was automatically updated to reflect the committed changes.

mjg added a commit: rS361695: Remove ->f_label from struct file.

Revision Contents
Changeset List

Path

Size

head/

sys/

file.h

4 lines

Diff 72536

View Options

Remove f_label from struct fileClosedPublicActions