Page MenuHomeFreeBSD
Differential D25036

Remove f_label from struct file
ClosedPublic
Actions

Authored by mjg on May 28 2020, 11:19 AM.
Tags
None
Referenced Files
F133527193: D25036.id72536.diff
Sun, Oct 26, 10:33 AM
F133466969: D25036.id.diff
Sun, Oct 26, 12:23 AM
Unknown Object (File)
Fri, Oct 24, 8:52 PM
Unknown Object (File)
Sat, Oct 18, 7:21 PM
Unknown Object (File)
Fri, Oct 17, 2:34 PM
Unknown Object (File)
Fri, Oct 17, 2:33 PM
Unknown Object (File)
Fri, Oct 17, 2:33 PM
Unknown Object (File)
Fri, Oct 17, 5:50 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
rwatson
Commits
rS361695: Remove ->f_label from struct file
Summary

The field was added in r141137 in 2005 and is unused (I did not check if something was using it at any point).

It avoidably grows a struct which is NOFREE and easily gets hundreds of thousands of instances.

Removing the field also allows D25024 at no extra size cost.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 31346

Event Timeline

mjg created this revision.May 28 2020, 11:19 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 28 2020, 11:19 AM
Harbormaster completed remote builds in B31346: Diff 72362.May 28 2020, 11:19 AM
mjg requested review of this revision.May 28 2020, 11:19 AM
mjg edited the summary of this revision. (Show Details)
kib accepted this revision.May 28 2020, 4:37 PM
This revision is now accepted and ready to land.May 28 2020, 4:37 PM
Closed by commit rS361695: Remove ->f_label from struct file (authored by mjg). · Explain WhyJun 1 2020, 3:58 PM
This revision was automatically updated to reflect the committed changes.
mjg added a commit: rS361695: Remove ->f_label from struct file.

Revision Contents
Changeset List

PathSize
sys/
sys/
4 lines

Diff 72362

View Options

sys/sys/file.h

Loading...