Page MenuHomeFreeBSD

Remove f_label from struct file
ClosedPublic

Authored by mjg on May 28 2020, 11:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 12:52 AM
Unknown Object (File)
Fri, Mar 22, 12:52 AM
Unknown Object (File)
Fri, Mar 22, 12:52 AM
Unknown Object (File)
Fri, Mar 22, 12:40 AM
Unknown Object (File)
Jan 18 2024, 7:07 AM
Unknown Object (File)
Dec 20 2023, 3:46 AM
Unknown Object (File)
Dec 17 2023, 10:05 PM
Unknown Object (File)
Nov 11 2023, 11:13 PM
Subscribers

Details

Summary

The field was added in r141137 in 2005 and is unused (I did not check if something was using it at any point).

It avoidably grows a struct which is NOFREE and easily gets hundreds of thousands of instances.

Removing the field also allows D25024 at no extra size cost.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mjg requested review of this revision.May 28 2020, 11:19 AM
mjg edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.May 28 2020, 4:37 PM
This revision was automatically updated to reflect the committed changes.