remove guards around installing loader.rc and menu.rc
ClosedPublic
Actions

Authored by allanjude on Jul 23 2015, 7:57 PM.

Details

Reviewers

dteske
eadler
julian
lifanov_mail.lifanov.com
marcel
bapt
loos

Commits

rS286368: Remove guards around overwriting loader.rc and menu.rc

Summary

On head, loader.rc and menu.rc files are not updated
on installworld. This is no longer necessary since loader.rc.local
and menu.rc.local files are parsed for local overrides.
The guards that protect this installation can be removed.

There is a Bugzilla 183765 about it.

Test Plan

Apply patch, make a change to menu.rc/loader.rc,
make installworld, and check that the file was replaced with built
version.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

lifanov_mail.lifanov.com updated this revision to Diff 7236.Jul 23 2015, 7:57 PM

lifanov_mail.lifanov.com retitled this revision from to remove guards around installing loader.rc and menu.rc.

lifanov_mail.lifanov.com updated this object.

lifanov_mail.lifanov.com edited the test plan for this revision. (Show Details)

lifanov_mail.lifanov.com added reviewers: dteske, loos.

Herald added a subscriber: imp. · View Herald TranscriptJul 23 2015, 7:57 PM

allanjude added a reviewer: allanjude.Jul 24 2015, 12:15 AM

eadler accepted this revision.Jul 25 2015, 7:28 PM

eadler added a reviewer: eadler.

This revision is now accepted and ready to land.Jul 25 2015, 7:28 PM

Is this ready to commit?

allanjude added reviewers: bapt, marcel, julian.Aug 5 2015, 3:07 PM

If you are going to replace a file, then you need to have a big banner in that file saying
"this file will be replaced automaitcally on upgrade. Do not edit it.
Please put any local changes in /boot/rc.loader.local"