Fix pci-passthru MSI issues with OpenBSD guests.
ClosedPublic
Actions

Authored by grehan on May 22 2020, 8:56 AM.

Details

Reviewers

bz
jhb

Group Reviewers

bhyve

Commits

rS361442: Fix pci-passthru MSI issues with OpenBSD guests

Summary

Return 2 x 16-bit registers in the correct byte order for a 4-byte read that spands the CMD/STATUS register. This reversal was hiding the capabilities-list, which prevented the MSI capability from being found for XHCI passthru.

Reorganize MSI/MSI-x config writes so that a 4-byte write at the capability offset would have the read-only portion skipped. This prevented MSI interrupts from being enabled.

PR 245392

Reported and tested by: Anatoli (me at anatoli dot ws)

Test Plan

Set up an OpenBSD guest with a passthru device.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

grehan created this revision.May 22 2020, 8:56 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMay 22 2020, 8:56 AM

Harbormaster completed remote builds in B31230: Diff 72107.May 22 2020, 8:56 AM

grehan requested review of this revision.May 22 2020, 8:56 AM

I think this is fine. The other design option would be to have pci_emul_capwrite to always require the explicit offset and id and move the while loop out into a helper function (pci_emul_lookup_cap or some such) that pci_cfgrw would use.

This revision is now accepted and ready to land.May 22 2020, 3:39 PM

Closed by commit rS361442: Fix pci-passthru MSI issues with OpenBSD guests (authored by grehan). · Explain WhyMay 25 2020, 6:25 AM

This revision was automatically updated to reflect the committed changes.

grehan added a commit: rS361442: Fix pci-passthru MSI issues with OpenBSD guests.