libkern: Add arc4random_uniform
ClosedPublic
Actions

Authored by manu on May 22 2020, 5:21 PM.

Details

Reviewers

• hselasky
cem
emaste
jmg

Commits

rS361418: libkern: Add arc4random_uniform

Summary

This variant get a random number up to the limit passed as the argument.
This is simply a copy of the libc version.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

manu created this revision.May 22 2020, 5:21 PM

Herald added a reviewer: jmg. · View Herald TranscriptMay 22 2020, 5:21 PM

Herald added a subscriber: imp. · View Herald Transcript

manu requested review of this revision.May 22 2020, 5:21 PM

manu added a child revision: D24961: linuxkpi: Add prandom_u32_max.

Hm, libc version is (or was) a separate file with a different copyright. Usual pattern in libkern is to just copy the libc files to libkern verbatim and only fixup as needed to compile. I don't know that we always have to do that, but we should at least confirm the arc4random_uniform copyright follows the code.

In D24962#549612, @cem wrote:

Hm, libc version is (or was) a separate file with a different copyright. Usual pattern in libkern is to just copy the libc files to libkern verbatim and only fixup as needed to compile. I don't know that we always have to do that, but we should at least confirm the arc4random_uniform copyright follows the code.

Right, I didn't pay attention to the licence of the file when I opened it. I'll fix that in a bit

• hselasky accepted this revision.May 22 2020, 6:06 PM

This revision is now accepted and ready to land.May 22 2020, 6:06 PM

manu updated this revision to Diff 72131.May 23 2020, 12:08 PM

This revision now requires review to proceed.May 23 2020, 12:08 PM

Thanks!

This revision is now accepted and ready to land.May 23 2020, 4:09 PM

Closed by commit rS361418: libkern: Add arc4random_uniform (authored by manu). · Explain WhyMay 23 2020, 5:51 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rS361418: libkern: Add arc4random_uniform.

manu mentioned this in rS364671: MFC r361247, r361343, r361418-r361419, r361422, r361449.Aug 24 2020, 1:00 PM