Differential D24462

vmm(4): Decode 3-byte VEX-prefixed instructions
ClosedPublic
Actions

Authored by cem on Apr 17 2020, 4:45 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 15, 1:42 PM

	Unknown Object (File)
	Sun, Apr 12, 5:27 PM

	Unknown Object (File)
	Sat, Apr 11, 6:05 AM

	Unknown Object (File)
	Sat, Apr 4, 4:50 PM

	Unknown Object (File)
	Sat, Apr 4, 4:34 AM

	Unknown Object (File)
	Fri, Apr 3, 11:48 PM

	Unknown Object (File)
	Fri, Apr 3, 9:49 PM

	Unknown Object (File)
	Thu, Apr 2, 11:01 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS360176: vmm(4): Decode 3-byte VEX-prefixed instructions

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem created this revision.Apr 17 2020, 4:45 AM

Herald added subscribers: bcran, rgrimes. · View Herald TranscriptApr 17 2020, 4:45 AM

Harbormaster completed remote builds in B30554: Diff 70675.Apr 17 2020, 4:46 AM

cem added a parent revision: D24461: vmm.h: Add ABI assertions and mark implicit holes.Apr 17 2020, 4:48 AM

cem added a child revision: D24463: vmm(4): Decode and emulate BEXTR.

grehan accepted this revision.Apr 17 2020, 5:09 AM

grehan added inline comments.

sys/amd64/include/vmm.h
555 ↗	(On Diff #70675)	Very tiny nit: should the bit-field declaration follow the same style as the modrm and SIB-byte decls, with comma separated fields ?

This revision is now accepted and ready to land.Apr 17 2020, 5:09 AM

cem added inline comments.Apr 17 2020, 1:58 PM

sys/amd64/include/vmm.h
555 ↗	(On Diff #70675)	Sure, that seems consistent with prevailing style. I’ll plan to make the change but won’t rush to push it to phab, if that’s alright.

grehan added inline comments.Apr 18 2020, 12:23 PM

sys/amd64/include/vmm.h
555 ↗	(On Diff #70675)	That's fine.

Closed by commit rS360176: vmm(4): Decode 3-byte VEX-prefixed instructions (authored by cem). · Explain WhyApr 21 2020, 9:33 PM

This revision was automatically updated to reflect the committed changes.

cem marked an inline comment as done.

cem added a commit: rS360176: vmm(4): Decode 3-byte VEX-prefixed instructions.

Herald added a subscriber: imp. · View Herald TranscriptApr 21 2020, 9:33 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

amd64/

include/

9 lines

vmm/

vmm_instruction_emul.c

86 lines

Diff 70858

head/sys/amd64/include/vmm.h

Loading...

head/sys/amd64/vmm/vmm_instruction_emul.c

Loading...