Details
Details
- Reviewers
grehan - Group Reviewers
bhyve - Commits
- rS360176: vmm(4): Decode 3-byte VEX-prefixed instructions
Diff Detail
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 30554 Build 28299: arc lint + arc unit
Event Timeline
sys/amd64/include/vmm.h | ||
---|---|---|
555 | Very tiny nit: should the bit-field declaration follow the same style as the modrm and SIB-byte decls, with comma separated fields ? |
sys/amd64/include/vmm.h | ||
---|---|---|
555 | Sure, that seems consistent with prevailing style. I’ll plan to make the change but won’t rush to push it to phab, if that’s alright. |
sys/amd64/include/vmm.h | ||
---|---|---|
555 | That's fine. |