Page MenuHomeFreeBSD
Differential D24462

vmm(4): Decode 3-byte VEX-prefixed instructions
ClosedPublic
Actions

Authored by cem on Apr 17 2020, 4:45 AM.
Tags
None
Referenced Files
F132121796: D24462.id70858.diff
Mon, Oct 13, 10:38 PM
F132121781: D24462.id.diff
Mon, Oct 13, 10:38 PM
F132121778: D24462.id70675.diff
Mon, Oct 13, 10:38 PM
F132112891: D24462.id70858.diff
Mon, Oct 13, 8:12 PM
Unknown Object (File)
Mon, Oct 13, 8:58 AM
Unknown Object (File)
Sun, Oct 12, 11:59 AM
Unknown Object (File)
Sun, Oct 12, 8:02 AM
Unknown Object (File)
Aug 18 2025, 6:26 AM
View All 91 Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
grehan
Group Reviewers
bhyve
Commits
rS360176: vmm(4): Decode 3-byte VEX-prefixed instructions

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30554
Build 28299: arc lint + arc unit

Event Timeline

cem created this revision.Apr 17 2020, 4:45 AM
Herald added subscribers: bcran, rgrimes. · View Herald TranscriptApr 17 2020, 4:45 AM
Harbormaster completed remote builds in B30554: Diff 70675.Apr 17 2020, 4:46 AM
cem added a parent revision: D24461: vmm.h: Add ABI assertions and mark implicit holes.Apr 17 2020, 4:48 AM
cem added a child revision: D24463: vmm(4): Decode and emulate BEXTR.
grehan accepted this revision.Apr 17 2020, 5:09 AM
grehan added inline comments.
sys/amd64/include/vmm.h
555

Very tiny nit: should the bit-field declaration follow the same style as the modrm and SIB-byte decls, with comma separated fields ?

This revision is now accepted and ready to land.Apr 17 2020, 5:09 AM
cem added inline comments.Apr 17 2020, 1:58 PM
sys/amd64/include/vmm.h
555

Sure, that seems consistent with prevailing style. I’ll plan to make the change but won’t rush to push it to phab, if that’s alright.

grehan added inline comments.Apr 18 2020, 12:23 PM
sys/amd64/include/vmm.h
555

That's fine.

Closed by commit rS360176: vmm(4): Decode 3-byte VEX-prefixed instructions (authored by cem). · Explain WhyApr 21 2020, 9:33 PM
This revision was automatically updated to reflect the committed changes.
cem marked an inline comment as done.
cem added a commit: rS360176: vmm(4): Decode 3-byte VEX-prefixed instructions.
Herald added a subscriber: imp. · View Herald TranscriptApr 21 2020, 9:33 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
include/
9 lines
vmm/
86 lines

Diff 70675

View Options

sys/amd64/include/vmm.h

Loading...
View Options

sys/amd64/vmm/vmm_instruction_emul.c

Loading...