Details

Reviewers

br
markj

Group Reviewers

riscv

Commits

rS360083: RISC-V: use physmem to manage physical memory

Summary

Replace our hand-rolled functions with the generic ones provided by
kern/subr_physmem.c. This greatly simplifies the initialization of
physical memory regions and kernel globals.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30045
Build 27856: arc lint + arc unit

Event Timeline

mhorne created this revision.Mar 22 2020, 6:38 PM

Harbormaster completed remote builds in B30045: Diff 69774.Mar 22 2020, 6:39 PM

mhorne added a parent revision: D24153: Convert arm's physmem interface to MI code.Mar 22 2020, 6:41 PM

mhorne added a child revision: D24155: RISC-V: exclude reserved memory regions.

I've found this to fail to boot, because it didn't reserve memory for the DTB (supplied by BBL). I'm not entirely sure if that's a result of an issue with your patch, or if there's something wrong in our local tree.

How is the DTB memory supposed to be reserved?

The following fixes the immediate problem for me:

@@ -806,9 +808,11 @@ initriscv(struct riscv_bootparams *rvbp)
 #ifdef FDT
        try_load_dtb(kmdp, rvbp->dtbp_virt);
 #endif
+       /* Reserve memory for the DTB. */
+       physmem_exclude_region(rvbp->dtbp_phys, L2_SIZE, EXFLAG_NOALLOC);

In D24154#532404, @kp wrote:
I've found this to fail to boot, because it didn't reserve memory for the DTB (supplied by BBL). I'm not entirely sure if that's a result of an issue with your patch, or if there's something wrong in our local tree.

How is the DTB memory supposed to be reserved?

The following fixes the immediate problem for me:
@@ -806,9 +808,11 @@ initriscv(struct riscv_bootparams *rvbp)
 #ifdef FDT
        try_load_dtb(kmdp, rvbp->dtbp_virt);
 #endif
+       /* Reserve memory for the DTB. */
+       physmem_exclude_region(rvbp->dtbp_phys, L2_SIZE, EXFLAG_NOALLOC);

Looks like I missed linking one of the parents. This patch also depends on D24152.

mhorne added a parent revision: D24152: RISC-V: copy the DTB to early KVA.Mar 27 2020, 5:42 PM

Rebase.

Harbormaster completed remote builds in B30144: Diff 69943.Mar 27 2020, 11:49 PM