fix atp mouse driver attachment on powermac g4
ClosedPublic
Actions

Authored by alfredo on Mar 9 2020, 11:37 AM.

Details

Reviewers

• hselasky
bdragon
jhibbits

Commits

rS359015: atp: fix mouse attachment on PowerBook5,6 (G4)

Summary

The atp driver is failing to attach on PowerBook G4 equipped with product ID 0x020e.

This device gives an error when trying to switch device to RAW_SENSOR_MODE. It seems that Fountain-based devices doesn't support this command.

Test Plan

trackpad mouse tested on powerBookG4 model PowerBook5,6

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alfredo created this revision.Mar 9 2020, 11:37 AM

Herald added a subscriber: luporl. · View Herald TranscriptMar 9 2020, 11:37 AM

Harbormaster completed remote builds in B29852: Diff 69322.Mar 9 2020, 11:37 AM

Looks good to me. Can you provide dmesg?

This revision is now accepted and ready to land.Mar 9 2020, 12:50 PM

• hselasky edited the summary of this revision. (Show Details)Mar 9 2020, 12:50 PM

In D24005#527782, @hselasky wrote:

Looks good to me. Can you provide dmesg?

Sure, would you like to have dmesg with the patch applied or prior the patch?

w/ patch

dmesg.txt7 KBDownload

Changes look good to me!

Closed by commit rS359015: atp: fix mouse attachment on PowerBook5,6 (G4) (authored by alfredo). · Explain WhyMar 16 2020, 1:53 PM

This revision was automatically updated to reflect the committed changes.

alfredo added a commit: rS359015: atp: fix mouse attachment on PowerBook5,6 (G4).

Herald added a subscriber: imp. · View Herald TranscriptMar 16 2020, 1:53 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

usb/

input/

atp.c

14 lines

Diff 69567

View Options

head/sys/dev/usb/input/atp.c

fix atp mouse driver attachment on powermac g4ClosedPublicActions