Page MenuHomeFreeBSD
Differential D3059

savecore: add support for gzip kernel dumps
AbandonedPublic
Actions

Authored by markj on Jul 12 2015, 2:19 AM.
Tags
None
Referenced Files
F122456491: D3059.id.diff
Sat, Jul 5, 11:46 AM
F122453104: D3059.id6896.diff
Sat, Jul 5, 11:06 AM
F122437639: D3059.id6869.diff
Sat, Jul 5, 8:33 AM
F122432032: D3059.id.diff
Sat, Jul 5, 7:39 AM
Unknown Object (File)
Thu, Jul 3, 1:15 AM
Unknown Object (File)
Tue, Jul 1, 4:33 AM
Unknown Object (File)
Thu, Jun 19, 1:20 PM
Unknown Object (File)
Thu, Jun 19, 1:19 PM
View All Files
Subscribers
asomers
bdrewery
cem
imp

Details

Reviewers
rstone
Summary

Most of the changes are little touchups:

  • Add a subroutine, compare_magic, for comparing the magic field of a dump header.
  • We now use the dumpextent field of the trailing dump header to locate the leading dump header.
  • DoRegularFile needs to do reads in multiples of the device's sector size, but with compressed dumps we may need to do a read that doesn't end on a sector boundary.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

markj updated this revision to Diff 6869.Jul 12 2015, 2:19 AM
markj retitled this revision from to savecore: add support for gzip kernel dumps.
markj edited the test plan for this revision. (Show Details)
markj added a reviewer: rstone.
markj updated this object.
markj added a subscriber: cem.
Herald added a subscriber: imp. · View Herald TranscriptJul 12 2015, 2:19 AM
cem added inline comments.Jul 12 2015, 3:47 PM
sbin/savecore/savecore.c
707

I don't have operator precedence memorized for these ones. Can we add a pair of parentheses around (compress || isgzipdump)?

markj updated this revision to Diff 6896.Jul 13 2015, 6:38 PM
  • - use parens to make an expression easier to parse
markj marked an inline comment as done.Jul 13 2015, 6:38 PM
cem added a comment.Jul 13 2015, 7:43 PM

Looks good to me.

bdrewery added a subscriber: bdrewery.Sep 11 2015, 9:24 PM
bdrewery added inline comments.
sbin/savecore/savecore.c
563

sizeof()

593

sizeof()

asomers added a subscriber: asomers.Oct 22 2015, 4:54 PM
asomers mentioned this in D2587: Disable free space checking in savecore..Oct 22 2015, 5:03 PM
markj abandoned this revision.Oct 25 2017, 1:55 AM

Revision Contents
Changeset List

PathSize
sbin/
savecore/
61 lines

Diff 6896

View Options

sbin/savecore/savecore.c

Loading...