Page MenuHomeFreeBSD

savecore: add support for gzip kernel dumps
AbandonedPublic

Authored by markj on Jul 12 2015, 2:19 AM.
Tags
None
Referenced Files
F68614818: D3059.id6896.diff
Sun, Oct 1, 7:19 PM
F68586215: D3059.id6869.diff
Sun, Oct 1, 6:48 AM
Unknown Object (File)
Fri, Sep 15, 7:08 PM
Unknown Object (File)
Aug 25 2023, 10:19 PM
Unknown Object (File)
Aug 10 2023, 6:37 PM
Unknown Object (File)
Jul 5 2023, 1:10 AM
Unknown Object (File)
Jun 27 2023, 7:55 AM
Unknown Object (File)
Jun 25 2023, 3:07 PM

Details

Reviewers
rstone
Summary

Most of the changes are little touchups:

  • Add a subroutine, compare_magic, for comparing the magic field of a dump header.
  • We now use the dumpextent field of the trailing dump header to locate the leading dump header.
  • DoRegularFile needs to do reads in multiples of the device's sector size, but with compressed dumps we may need to do a read that doesn't end on a sector boundary.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

markj retitled this revision from to savecore: add support for gzip kernel dumps.
markj edited the test plan for this revision. (Show Details)
markj added a reviewer: rstone.
markj updated this object.
markj added a subscriber: cem.
sbin/savecore/savecore.c
707

I don't have operator precedence memorized for these ones. Can we add a pair of parentheses around (compress || isgzipdump)?

  • - use parens to make an expression easier to parse
bdrewery added inline comments.
sbin/savecore/savecore.c
563

sizeof()

593

sizeof()