Page MenuHomeFreeBSD

savecore: add support for gzip kernel dumps
AbandonedPublic

Authored by markj on Jul 12 2015, 2:19 AM.
Tags
None
Referenced Files
F61971191: D3059.diff
Mon, May 29, 9:27 AM
Unknown Object (File)
Fri, May 12, 10:05 AM
Unknown Object (File)
Sat, May 6, 12:51 AM
Unknown Object (File)
Fri, May 5, 1:57 PM
Unknown Object (File)
Mar 22 2023, 8:11 AM
Unknown Object (File)
Mar 5 2023, 7:26 AM
Unknown Object (File)
Feb 13 2023, 11:44 PM
Unknown Object (File)
Dec 19 2022, 8:19 PM

Details

Reviewers
rstone
Summary

Most of the changes are little touchups:

  • Add a subroutine, compare_magic, for comparing the magic field of a dump header.
  • We now use the dumpextent field of the trailing dump header to locate the leading dump header.
  • DoRegularFile needs to do reads in multiples of the device's sector size, but with compressed dumps we may need to do a read that doesn't end on a sector boundary.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

markj retitled this revision from to savecore: add support for gzip kernel dumps.
markj edited the test plan for this revision. (Show Details)
markj added a reviewer: rstone.
markj updated this object.
markj added a subscriber: cem.
sbin/savecore/savecore.c
707

I don't have operator precedence memorized for these ones. Can we add a pair of parentheses around (compress || isgzipdump)?

  • - use parens to make an expression easier to parse
bdrewery added inline comments.
sbin/savecore/savecore.c
563

sizeof()

593

sizeof()