Generalise the arm64 ASID allocator
ClosedPublic
Actions

Authored by andrew on Feb 25 2020, 12:04 PM.

Details

Reviewers

markj
alc
manu

Group Reviewers

arm64

Commits

rS358328: Generalise the arm64 ASID allocator.

Summary

The requirements of an Address Space ID allocator and a Virtual Machine ID
allocator are similar. Generalise the former code so it can be used with
the latter.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29599
Build 27460: arc lint + arc unit

Event Timeline

andrew created this revision.Feb 25 2020, 12:04 PM

Herald added a reviewer: manu. · View Herald TranscriptFeb 25 2020, 12:04 PM

Herald added a subscriber: emaste. · View Herald Transcript

Harbormaster completed remote builds in B29595: Diff 68796.Feb 25 2020, 12:04 PM

Remove an unused variable

Harbormaster completed remote builds in B29599: Diff 68800.Feb 25 2020, 1:37 PM

Is your overall strategy to incrementally replace PMAP_ASSERT_STAGE1(pmap)'s by correct handling of stage 2 PTE?

sys/arm64/arm64/pmap.c
998	I would suggest moving the second sentence inside pmap_init_asids() and change the wording to: "We may be too early in ..."
5882	if (pmap->pm_stage == PM_STAGE1) ... else ...?

This revision is now accepted and ready to land.Feb 25 2020, 4:50 PM

In D23831#523873, @alc wrote:

Is your overall strategy to incrementally replace PMAP_ASSERT_STAGE1(pmap)'s by correct handling of stage 2 PTE?

Yes. I'm currently working on pmap_enter and just need to implement cache and tlb handling for it.

sys/arm64/arm64/pmap.c
5882	I'll add `PMAP_ASSERT_STAGE1(pmap);` for now as the process for VMID reset looks like it will be more complex, e.g. may need to call into the hypervisor.