bridge: Move locking defines into if_bridge.c
ClosedPublic
Actions

Authored by kp on Feb 23 2020, 5:31 PM.

Details

Reviewers

emaste
philip

Group Reviewers

network

Commits

rS358325: bridge: Move locking defines into if_bridge.c

Summary

The locking defines for if_bridge used to live in if_bridgevar.h, but
they're only ever used by the bridge implementation itself (in
if_bridge.c). Moving them into the .c file.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29557
Build 27419: arc lint + arc unit

Event Timeline

kp created this revision.Feb 23 2020, 5:31 PM

Herald added subscribers: melifaro, ae. · View Herald TranscriptFeb 23 2020, 5:31 PM

Harbormaster completed remote builds in B29557: Diff 68713.Feb 23 2020, 5:31 PM

Good idea. There should be no reason for the bridge locks to be manipulated elsewhere.

This revision is now accepted and ready to land.Feb 24 2020, 5:18 AM

It seems some of these macros should be fixed to respect style(9) and use tab instead of space after #define.

In D23808#523738, @ae wrote:

It seems some of these macros should be fixed to respect style(9) and use tab instead of space after #define.

I'm planning major changes to the bridge locking, so those macros are almost certainly going to be changed anyway. Moving them is a first step, to be doubly sure that they're not used in unexpected places. (And also, because the locking strategy really should be private to the bridge code).

emaste accepted this revision.Feb 25 2020, 5:20 PM

Closed by commit rS358325: bridge: Move locking defines into if_bridge.c (authored by kp). · Explain WhyFeb 26 2020, 8:47 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rS358325: bridge: Move locking defines into if_bridge.c.

Herald added a subscriber: imp. · View Herald TranscriptFeb 26 2020, 8:47 AM