Use NET_TASK_INIT() and NET_GROUPTASK_INIT() for drivers that process incoming packets in taskqueue context.
ClosedPublic
Actions

Authored by • hselasky on Feb 18 2020, 4:02 PM.

Details

Reviewers

jeff
glebius
rscheff

Commits

rS358081: Use NET_TASK_INIT() and NET_GROUPTASK_INIT() for drivers that process

Summary

This patch extends r357772.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 29469

Event Timeline

• hselasky created this revision.Feb 18 2020, 4:02 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptFeb 18 2020, 4:02 PM

Harbormaster completed remote builds in B29469: Diff 68487.Feb 18 2020, 4:02 PM

• hselasky mentioned this in D23599: Add missing EPOCH(9) wrapper in ipfw.Feb 18 2020, 4:03 PM

There is something similar in sys/netpfil/pf/pf.c:880: TASK_INIT(&V_pf_overloadtask, 0, pf_overload_task, curvnet);

Guess that would need to be modified also?

Other than the above, that fixed the panic in dummynet.

This revision is now accepted and ready to land.Feb 18 2020, 4:13 PM

From what I can see "pf_overload_task()" does not send or receive and IP packets, and does not need to run under EPOCH(9).

glebius accepted this revision.Feb 18 2020, 7:38 PM

Closed by commit rS358081: Use NET_TASK_INIT() and NET_GROUPTASK_INIT() for drivers that process (authored by • hselasky). · Explain WhyFeb 18 2020, 7:53 PM

This revision was automatically updated to reflect the committed changes.

• hselasky added a commit: rS358081: Use NET_TASK_INIT() and NET_GROUPTASK_INIT() for drivers that process.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfw/

ip_dummynet.c

2 lines

Diff 68487

View Options

sys/netpfil/ipfw/ip_dummynet.c

Use NET_TASK_INIT() and NET_GROUPTASK_INIT() for drivers that process incoming packets in taskqueue context.ClosedPublicActions