Fixed bug where elf header field osabi is not set by objcopy
ClosedPublic
Actions

Authored by tig_freebsdfoundation.org on Feb 4 2020, 8:00 PM.

Details

Reviewers

emaste
markj
jkoshy_users.sourceforge.net
kaiw

Group Reviewers

manpages

Commits

rS357826: elfcopy: set ELF OS/ABI field when converting from binary

Summary

Added functions to set abi field of elfcopy structure when -o option is used.
PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228934

Test Plan

Using the test case in PR, OS/ABI correctly set after change.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tig_freebsdfoundation.org created this revision.Feb 4 2020, 8:00 PM

emaste added reviewers: markj, jkoshy_users.sourceforge.net, kaiw.Feb 7 2020, 2:30 PM

Looks good to me.

This revision is now accepted and ready to land.Feb 11 2020, 6:41 PM

jkoshy_users.sourceforge.net accepted this revision.Feb 11 2020, 10:43 PM

Closed by commit rS357826: elfcopy: set ELF OS/ABI field when converting from binary (authored by emaste). · Explain WhyFeb 12 2020, 4:00 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rS357826: elfcopy: set ELF OS/ABI field when converting from binary.

Herald added a reviewer: manpages. · View Herald TranscriptFeb 12 2020, 4:00 PM

Herald added a subscriber: imp. · View Herald Transcript

committed to FreeBSD, will upstream soon

Committed upstream as r3871

dim mentioned this in rS367466: Sync up elftoolchain with head, except for the capsicum-related commits,.Nov 7 2020, 11:58 PM

Revision Contents
Changeset List

Path

Size

head/

contrib/

elftoolchain/

elfcopy/

main.c

1 line

libelftc/

elftc.3

4 lines

elftc_bfd_find_target.3

4 lines

elftc_bfdtarget.c

7 lines

libelftc.h

1 line

Diff 68190

View Options

head/contrib/elftoolchain/elfcopy/main.c

View Options

head/contrib/elftoolchain/libelftc/elftc.3

View Options

head/contrib/elftoolchain/libelftc/elftc_bfd_find_target.3

View Options

head/contrib/elftoolchain/libelftc/elftc_bfdtarget.c

View Options

head/contrib/elftoolchain/libelftc/libelftc.h

Fixed bug where elf header field osabi is not set by objcopyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 68190

head/contrib/elftoolchain/elfcopy/main.c

head/contrib/elftoolchain/libelftc/elftc.3

head/contrib/elftoolchain/libelftc/elftc_bfd_find_target.3

head/contrib/elftoolchain/libelftc/elftc_bfdtarget.c

head/contrib/elftoolchain/libelftc/libelftc.h

Fixed bug where elf header field osabi is not set by objcopy
ClosedPublic
Actions

Revision Contents
Changeset List