Page MenuHomeFreeBSD

tig_freebsdfoundation.org (Tiger Gao)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 9 2020, 2:26 PM (13 w, 13 h)

Recent Activity

Tue, Apr 7

tig_freebsdfoundation.org updated the summary of D24327: Add new casper execuion service.
Tue, Apr 7, 5:41 PM · capsicum
tig_freebsdfoundation.org created D24327: Add new casper execuion service.
Tue, Apr 7, 5:32 PM · capsicum

Fri, Mar 20

tig_freebsdfoundation.org added inline comments to D24140: readelf: simplify Xen string note printing.
Fri, Mar 20, 5:30 PM

Wed, Mar 11

tig_freebsdfoundation.org added a comment to D23744: Added casper service to logger.

Yes that would be great. Please go ahead.

Wed, Mar 11, 2:41 PM

Mar 6 2020

tig_freebsdfoundation.org added a comment to D23744: Added casper service to logger.

Any further comments? If not, feel free to accept this revision.

Mar 6 2020, 7:38 PM

Feb 28 2020

tig_freebsdfoundation.org updated the diff for D23782: Add label checks when DW_AT_range and DW_AT_low_pc cannot be used.
Feb 28 2020, 2:30 PM
tig_freebsdfoundation.org added inline comments to D23782: Add label checks when DW_AT_range and DW_AT_low_pc cannot be used.
Feb 28 2020, 2:30 PM

Feb 21 2020

tig_freebsdfoundation.org added inline comments to D23782: Add label checks when DW_AT_range and DW_AT_low_pc cannot be used.
Feb 21 2020, 5:47 PM
tig_freebsdfoundation.org updated the diff for D23782: Add label checks when DW_AT_range and DW_AT_low_pc cannot be used.
Feb 21 2020, 5:46 PM
tig_freebsdfoundation.org added a comment to D23782: Add label checks when DW_AT_range and DW_AT_low_pc cannot be used.

It looks like it's just the allocated memory for labels, as most of the memory used by check_labels are given back (freed) according to the picture.
Kernel probably has a lot of assembly files with a lot of labels. Is memory usage a problem?

Feb 21 2020, 4:19 PM
tig_freebsdfoundation.org added a comment to D23501: Added ranges to Addr2line.
Feb 21 2020, 4:19 PM
tig_freebsdfoundation.org added a comment to D23782: Add label checks when DW_AT_range and DW_AT_low_pc cannot be used.

Check labels seems to be using a lot of memory (20 Mb). There might be a bug somewhere. I'm looking into it.

Feb 21 2020, 3:59 PM
tig_freebsdfoundation.org updated the summary of D23782: Add label checks when DW_AT_range and DW_AT_low_pc cannot be used.
Feb 21 2020, 2:37 PM
tig_freebsdfoundation.org created D23782: Add label checks when DW_AT_range and DW_AT_low_pc cannot be used.
Feb 21 2020, 2:35 PM

Feb 19 2020

tig_freebsdfoundation.org added inline comments to D23744: Added casper service to logger.
Feb 19 2020, 4:30 PM
tig_freebsdfoundation.org updated the diff for D23744: Added casper service to logger.
Feb 19 2020, 4:30 PM
tig_freebsdfoundation.org added inline comments to D23744: Added casper service to logger.
Feb 19 2020, 4:27 PM
tig_freebsdfoundation.org updated the diff for D23744: Added casper service to logger.
Feb 19 2020, 4:27 PM
tig_freebsdfoundation.org added inline comments to D23744: Added casper service to logger.
Feb 19 2020, 4:10 PM
tig_freebsdfoundation.org updated the diff for D23744: Added casper service to logger.
Feb 19 2020, 4:10 PM
tig_freebsdfoundation.org updated the diff for D23744: Added casper service to logger.

Added Makefile changes.

Feb 19 2020, 3:44 PM

Feb 18 2020

tig_freebsdfoundation.org added inline comments to D23744: Added casper service to logger.
Feb 18 2020, 10:50 PM
tig_freebsdfoundation.org updated the diff for D23744: Added casper service to logger.
Feb 18 2020, 10:49 PM
tig_freebsdfoundation.org updated the diff for D23744: Added casper service to logger.
Feb 18 2020, 7:13 PM
tig_freebsdfoundation.org created D23744: Added casper service to logger.
Feb 18 2020, 6:21 PM

Feb 11 2020

tig_freebsdfoundation.org added a comment to D23501: Added ranges to Addr2line.

I added in line 482

if (lopc == curlopc)
				return (DW_DLV_ERROR);

for the case when DW_AT_Range is present so the program stops when we can't find an address.

Feb 11 2020, 10:07 PM
tig_freebsdfoundation.org updated the diff for D23501: Added ranges to Addr2line.
Feb 11 2020, 10:04 PM
tig_freebsdfoundation.org updated the diff for D23501: Added ranges to Addr2line.

Added comment on check_range()

Feb 11 2020, 9:56 PM

Feb 7 2020

tig_freebsdfoundation.org updated the diff for D23501: Added ranges to Addr2line.

-f and -i flag outputs are now the same as original.
collect_func() needs gdb to get function name, so I added a field a CU to store this info in the cache.

Feb 7 2020, 10:41 PM
tig_freebsdfoundation.org abandoned D23350: Added Single Entry Cache to addr2line.
Feb 7 2020, 7:16 PM
tig_freebsdfoundation.org updated the diff for D23501: Added ranges to Addr2line.
  1. I fixed the issues mentioned in the code comments.
  2. I tested the performance with curlopc and with resetting cu to first cu every time(v2), below is the results:


r=reverse
seq=sequential
rand=random
v1 is addr2line with curlopc
v2 is the version that resets cu to first cu for every translation
10000seq stores 10k sorted addr of first 20k kernel addr.
1000rand stores 1k rand addr in all of kernel addr
r10000seq is 10000seq reversed
Which version should I keep?

  1. I didn't test with -f -i before. And having tested it just now I realized the output between the old version and my patch looks different. I'm looking into it now.
Feb 7 2020, 6:11 PM
tig_freebsdfoundation.org updated the diff for D23571: Fixed bug where elfcopy --add-section needs to be called twice for section to be created.
Feb 7 2020, 3:58 PM
tig_freebsdfoundation.org created D23571: Fixed bug where elfcopy --add-section needs to be called twice for section to be created.
Feb 7 2020, 3:56 PM

Feb 6 2020

tig_freebsdfoundation.org updated the diff for D23501: Added ranges to Addr2line.
Feb 6 2020, 4:17 PM
tig_freebsdfoundation.org updated the diff for D23501: Added ranges to Addr2line.
Feb 6 2020, 4:15 PM

Feb 4 2020

tig_freebsdfoundation.org created D23504: Fixed bug where elf header field osabi is not set by objcopy.
Feb 4 2020, 8:00 PM
tig_freebsdfoundation.org updated the diff for D23501: Added ranges to Addr2line.
Feb 4 2020, 4:47 PM
tig_freebsdfoundation.org updated the summary of D23501: Added ranges to Addr2line.
Feb 4 2020, 4:00 PM
tig_freebsdfoundation.org updated the diff for D23501: Added ranges to Addr2line.
Feb 4 2020, 3:59 PM
tig_freebsdfoundation.org created D23501: Added ranges to Addr2line.
Feb 4 2020, 3:47 PM

Feb 3 2020

tig_freebsdfoundation.org updated the diff for D23418: Added RB_TREE to addr2line.
Feb 3 2020, 3:56 PM

Jan 31 2020

tig_freebsdfoundation.org added inline comments to D23418: Added RB_TREE to addr2line.
Jan 31 2020, 7:23 PM
tig_freebsdfoundation.org added inline comments to D23418: Added RB_TREE to addr2line.
Jan 31 2020, 7:19 PM
tig_freebsdfoundation.org updated the diff for D23418: Added RB_TREE to addr2line.
Jan 31 2020, 7:18 PM
tig_freebsdfoundation.org updated the diff for D23418: Added RB_TREE to addr2line.
Jan 31 2020, 7:17 PM
tig_freebsdfoundation.org added a comment to D23418: Added RB_TREE to addr2line.

Updated. Current code is passing my tests.

Jan 31 2020, 6:52 PM
tig_freebsdfoundation.org updated the diff for D23418: Added RB_TREE to addr2line.
Jan 31 2020, 6:50 PM
tig_freebsdfoundation.org updated the diff for D23418: Added RB_TREE to addr2line.
Jan 31 2020, 6:49 PM
tig_freebsdfoundation.org added a comment to D23418: Added RB_TREE to addr2line.

I removed the useless node and now we check max node if nfind returns null. I guess useless node was indeed useless lol.

Jan 31 2020, 4:37 PM
tig_freebsdfoundation.org updated the diff for D23418: Added RB_TREE to addr2line.
Jan 31 2020, 4:36 PM

Jan 30 2020

tig_freebsdfoundation.org added a comment to D23418: Added RB_TREE to addr2line.

I fixed the issues according to the comments. We're using CU as tree node now and only allocate CU when addr is in the CU's range. The code looks much cleaner now.

Jan 30 2020, 5:09 PM
tig_freebsdfoundation.org updated the diff for D23418: Added RB_TREE to addr2line.
Jan 30 2020, 5:08 PM
tig_freebsdfoundation.org updated the diff for D23418: Added RB_TREE to addr2line.
Jan 30 2020, 2:04 PM

Jan 29 2020

tig_freebsdfoundation.org created D23418: Added RB_TREE to addr2line.
Jan 29 2020, 8:55 PM

Jan 28 2020

tig_freebsdfoundation.org updated the diff for D23350: Added Single Entry Cache to addr2line.
Jan 28 2020, 2:28 PM
tig_freebsdfoundation.org updated the diff for D23350: Added Single Entry Cache to addr2line.
Jan 28 2020, 2:21 PM
tig_freebsdfoundation.org added inline comments to D23350: Added Single Entry Cache to addr2line.
Jan 28 2020, 2:18 PM

Jan 27 2020

tig_freebsdfoundation.org added inline comments to D23350: Added Single Entry Cache to addr2line.
Jan 27 2020, 10:56 PM
tig_freebsdfoundation.org updated the diff for D23350: Added Single Entry Cache to addr2line.
Jan 27 2020, 10:54 PM
tig_freebsdfoundation.org added inline comments to D23350: Added Single Entry Cache to addr2line.
Jan 27 2020, 8:07 PM
tig_freebsdfoundation.org added inline comments to D23350: Added Single Entry Cache to addr2line.
Jan 27 2020, 8:06 PM
tig_freebsdfoundation.org added inline comments to D23350: Added Single Entry Cache to addr2line.
Jan 27 2020, 8:05 PM
tig_freebsdfoundation.org updated the diff for D23350: Added Single Entry Cache to addr2line.
Jan 27 2020, 8:04 PM
tig_freebsdfoundation.org added inline comments to D23350: Added Single Entry Cache to addr2line.
Jan 27 2020, 7:19 PM
tig_freebsdfoundation.org updated the diff for D23350: Added Single Entry Cache to addr2line.
Jan 27 2020, 6:52 PM
tig_freebsdfoundation.org updated the diff for D23350: Added Single Entry Cache to addr2line.
Jan 27 2020, 5:17 PM
tig_freebsdfoundation.org updated the test plan for D23350: Added Single Entry Cache to addr2line.
Jan 27 2020, 2:35 PM
tig_freebsdfoundation.org updated the diff for D23350: Added Single Entry Cache to addr2line.
Jan 27 2020, 2:34 PM
tig_freebsdfoundation.org added a comment to D23350: Added Single Entry Cache to addr2line.

Added random support in. The revision is ready for review now.

Jan 27 2020, 2:32 PM
tig_freebsdfoundation.org updated the diff for D23350: Added Single Entry Cache to addr2line.
Jan 27 2020, 2:31 PM
tig_freebsdfoundation.org updated the summary of D23350: Added Single Entry Cache to addr2line.
Jan 27 2020, 2:24 PM

Jan 24 2020

tig_freebsdfoundation.org added a comment to D23350: Added Single Entry Cache to addr2line.

I realized I need to change a small piece of code to support random access. Will update once done.

Jan 24 2020, 8:52 PM
tig_freebsdfoundation.org added a comment to D23350: Added Single Entry Cache to addr2line.

Updated.

Jan 24 2020, 6:43 PM
tig_freebsdfoundation.org updated the diff for D23350: Added Single Entry Cache to addr2line.
Jan 24 2020, 6:42 PM
tig_freebsdfoundation.org created D23350: Added Single Entry Cache to addr2line.
Jan 24 2020, 6:24 PM