Page MenuHomeFreeBSD
Differential D27466

elftoolchain/addr2line: fix bugs found by coverity
Needs ReviewPublic
Actions

Authored by tig_freebsdfoundation.org on Dec 3 2020, 9:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 7, 5:46 AM
Unknown Object (File)
Mar 13 2024, 5:29 PM
Unknown Object (File)
Feb 10 2024, 9:37 PM
Unknown Object (File)
Feb 3 2024, 8:15 AM
Unknown Object (File)
Dec 20 2023, 5:15 AM
Unknown Object (File)
Dec 12 2023, 6:23 PM
Unknown Object (File)
Jul 15 2023, 6:55 AM
Unknown Object (File)
Jun 30 2023, 4:48 AM
View All 12 Files
Subscribers
None

Details

Reviewers
emaste
Summary
  • set hipc to range->hipc in case of labels in collect_func()
  • deallocate die in case of error

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

tig_freebsdfoundation.org requested review of this revision.Dec 3 2020, 9:07 PM
tig_freebsdfoundation.org created this revision.
emaste added inline comments.Dec 4 2020, 5:24 PM
contrib/elftoolchain/addr2line/addr2line.c
466

do we need to check for prev_die == NULL as we do at line 480?

tig_freebsdfoundation.org updated this revision to Diff 80332.Dec 4 2020, 8:06 PM
tig_freebsdfoundation.org marked an inline comment as done.
tig_freebsdfoundation.org added inline comments.
contrib/elftoolchain/addr2line/addr2line.c
466

I think we do need to check for null in this case.

Revision Contents
Changeset List

PathSize
contrib/
elftoolchain/
addr2line/
11 lines

Diff 80332

View Options

contrib/elftoolchain/addr2line/addr2line.c

Loading...