[PowerPC] ELFv2 libdtrace support (userland side)
ClosedPublic
Actions

Authored by bdragon on Nov 16 2019, 3:58 AM.

Details

Reviewers

jhibbits
markj
gnn

Commits

rS357590: [PowerPC] [DTrace] Add ELFv2 support in libdtrace

Summary

PPC64 ELFv2 is a lot more "normal" than ELFv1. No more function descriptors means being able to switch back to the "regular" code that is used everywhere but PPC64 ELFv1.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bdragon created this revision.Nov 16 2019, 3:58 AM

Herald added a reviewer: gnn. · View Herald TranscriptNov 16 2019, 3:58 AM

Herald added a subscriber: imp. · View Herald Transcript

jhibbits added inline comments.Nov 17 2019, 4:52 AM

cddl/contrib/opensolaris/lib/libdtrace/common/dt_link.c
1403 ↗	(On Diff #64423)	On !ELFv2/PowerPC64, uses_funcdesc is uninitialized.

Actually initialize uses_funcdesc properly.

bdragon marked an inline comment as done.Nov 17 2019, 6:59 PM

markj accepted this revision.Nov 18 2019, 3:45 PM

jhibbits accepted this revision.Nov 18 2019, 3:53 PM

LGTM

This revision is now accepted and ready to land.Feb 5 2020, 7:25 PM

Herald added subscribers: alfredo, luporl. · View Herald TranscriptFeb 5 2020, 7:25 PM

Closed by commit rS357590: [PowerPC] [DTrace] Add ELFv2 support in libdtrace (authored by bdragon). · Explain WhyFeb 5 2020, 7:40 PM

This revision was automatically updated to reflect the committed changes.

bdragon added a commit: rS357590: [PowerPC] [DTrace] Add ELFv2 support in libdtrace.

Revision Contents
Changeset List

Path

Size

head/

cddl/

contrib/

opensolaris/

lib/

libdtrace/

common/

dt_link.c

14 lines

Diff 67823

View Options

head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_link.c

[PowerPC] ELFv2 libdtrace support (userland side)ClosedPublicActions