Differential D23433

loader: rewrite zfs reader zap code to use malloc
ClosedPublic
Actions

Authored by tsoome on Jan 30 2020, 8:33 PM.

Tags

None

Referenced Files

	F82885833: D23433.diff
	Fri, May 3, 2:25 PM

	Unknown Object (File)
	Fri, Apr 26, 11:23 PM

	Unknown Object (File)
	Fri, Apr 26, 11:21 PM

	Unknown Object (File)
	Fri, Apr 26, 11:21 PM

	Unknown Object (File)
	Fri, Apr 26, 11:21 PM

	Unknown Object (File)
	Fri, Apr 26, 11:21 PM

	Unknown Object (File)
	Fri, Apr 26, 9:30 PM

	Unknown Object (File)
	Mon, Apr 22, 4:40 AM

View All 37 Files

Subscribers

Details

Reviewers

kevans
imp
allanjude
delphij

Commits

rS357497: loader: rewrite zfs reader zap code to use malloc

Summary

First step on removing zfs_alloc.

Test Plan

I have used this implementation since 21 Nov 2019.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29144
Build 27080: arc lint + arc unit

Event Timeline

tsoome created this revision.Jan 30 2020, 8:33 PM

Herald added a subscriber: delphij. · View Herald TranscriptJan 30 2020, 8:33 PM

Harbormaster completed remote builds in B29054: Diff 67531.Jan 30 2020, 8:33 PM

replace if chain by switch. Print out entire zap_block_type.

Harbormaster completed remote builds in B29066: Diff 67556.Jan 31 2020, 4:12 PM

LGTM. There are a few minor nits but these are optional.

stand/libsa/zfs/zfsimpl.c
2465	Nit, optional: 'lp' is passed and from an on-stack variable, we could use it directly, e.g. lp = malloc(sizeof(*lp)) below.
2612	Nit, optional: I think it's better to have something like zap_leaf_free() that free's zl->l_phys and zl.

This revision is now accepted and ready to land.Feb 3 2020, 2:49 AM

Suggestions from delphij, thanks!

This revision now requires review to proceed.Feb 3 2020, 5:51 PM

Harbormaster completed remote builds in B29144: Diff 67725.Feb 3 2020, 5:51 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2020, 7:38 AM

Closed by commit rS357497: loader: rewrite zfs reader zap code to use malloc (authored by tsoome). · Explain Why

This revision was automatically updated to reflect the committed changes.

tsoome added a commit: rS357497: loader: rewrite zfs reader zap code to use malloc.

Revision Contents
Changeset List

Path

Size

stand/

i386/

zfsboot/

29 lines

libsa/

zfs/

434 lines

sys/

cddl/

boot/

zfs/

13 lines

Diff 67725

stand/i386/zfsboot/zfsboot.c

Loading...

stand/libsa/zfs/zfsimpl.c

Loading...

sys/cddl/boot/zfs/zfsimpl.h

Loading...