First step on removing zfs_alloc.
Details
Details
I have used this implementation since 21 Nov 2019.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 29144 Build 27080: arc lint + arc unit
Event Timeline
Comment Actions
LGTM. There are a few minor nits but these are optional.
stand/libsa/zfs/zfsimpl.c | ||
---|---|---|
2465 | Nit, optional: 'lp' is passed and from an on-stack variable, we could use it directly, e.g. *lp = malloc(sizeof(**lp)) below. | |
2612 | Nit, optional: I think it's better to have something like zap_leaf_free() that free's zl->l_phys and zl. |