Page MenuHomeFreeBSD
Differential D22987

Define a function combining vm entry lookup and clip-start
ClosedPublic
Actions

Authored by dougm on Jan 1 2020, 7:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 12, 1:15 AM
Unknown Object (File)
Tue, Nov 11, 9:43 AM
Unknown Object (File)
Mon, Nov 10, 8:33 AM
Unknown Object (File)
Fri, Oct 31, 5:26 AM
Unknown Object (File)
Sat, Oct 25, 5:09 PM
Unknown Object (File)
Tue, Oct 14, 9:25 PM
Unknown Object (File)
Oct 13 2025, 10:07 AM
Unknown Object (File)
Oct 1 2025, 9:29 AM
View All Files
Subscribers
imp
pho

Details

Reviewers
alc
markj
Commits
rS357073: Most uses of vm_map_clip_start follow a call to vm_map_lookup. Define
Summary

Most uses of vm_map_clip_start follow a call to vm_map_lookup. Define an inline function vm_map_lookup_clip_start that invokes them both and use it in places that invoke both. Drop a couple of local variables made unnecessary by this function.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm created this revision.Jan 1 2020, 7:48 AM
pho added a comment.Jan 1 2020, 8:27 PM

I ran a preliminary 5 hour tests + a buildworld with D22987.66203.diff on r356250. No problems seen.

dougm updated this revision to Diff 66269.Jan 2 2020, 9:35 PM

Add an important omitted line.

pho added a comment.Jan 5 2020, 5:18 AM

I ran a full stress2 test on r356314 + D22987.66269.diff. No problems seen.

dougm added a reviewer: markj.Jan 21 2020, 5:23 PM
dougm updated this revision to Diff 67217.Jan 23 2020, 5:21 PM

Resolve conflicts.

markj accepted this revision.Jan 23 2020, 5:51 PM

Seems reasonable to me.

sys/vm/vm_map.c
2418 ↗(On Diff #67217)

This line should be indented by four spaces.

3754 ↗(On Diff #67217)

This comment is still missing a period. I'm not sure it is very useful to begin with.

This revision is now accepted and ready to land.Jan 23 2020, 5:51 PM
Closed by commit rS357073: Most uses of vm_map_clip_start follow a call to vm_map_lookup. Define (authored by dougm). · Explain WhyJan 24 2020, 7:48 AM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rS357073: Most uses of vm_map_clip_start follow a call to vm_map_lookup. Define.
Herald added a subscriber: imp. · View Herald TranscriptJan 24 2020, 7:48 AM

Revision Contents
Changeset List

PathSize
head/
sys/
vm/
90 lines

Diff 67242

View Options

head/sys/vm/vm_map.c

Loading...