Page MenuHomeFreeBSD

Define a function combining vm entry lookup and clip-start
ClosedPublic

Authored by dougm on Jan 1 2020, 7:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 22, 2:22 PM
Unknown Object (File)
Fri, Jan 17, 5:48 PM
Unknown Object (File)
Tue, Jan 14, 5:26 AM
Unknown Object (File)
Fri, Jan 10, 3:10 AM
Unknown Object (File)
Dec 11 2024, 8:26 PM
Unknown Object (File)
Dec 2 2024, 10:21 PM
Unknown Object (File)
Nov 23 2024, 9:43 AM
Unknown Object (File)
Nov 22 2024, 12:30 AM
Subscribers

Details

Summary

Most uses of vm_map_clip_start follow a call to vm_map_lookup. Define an inline function vm_map_lookup_clip_start that invokes them both and use it in places that invoke both. Drop a couple of local variables made unnecessary by this function.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I ran a preliminary 5 hour tests + a buildworld with D22987.66203.diff on r356250. No problems seen.

Add an important omitted line.

I ran a full stress2 test on r356314 + D22987.66269.diff. No problems seen.

Seems reasonable to me.

sys/vm/vm_map.c
2418

This line should be indented by four spaces.

3754

This comment is still missing a period. I'm not sure it is very useful to begin with.

This revision is now accepted and ready to land.Jan 23 2020, 5:51 PM