Page MenuHomeFreeBSD

Define a function combining vm entry lookup and clip-start
ClosedPublic

Authored by dougm on Jan 1 2020, 7:48 AM.

Details

Summary

Most uses of vm_map_clip_start follow a call to vm_map_lookup. Define an inline function vm_map_lookup_clip_start that invokes them both and use it in places that invoke both. Drop a couple of local variables made unnecessary by this function.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dougm created this revision.Jan 1 2020, 7:48 AM
pho added a comment.Jan 1 2020, 8:27 PM

I ran a preliminary 5 hour tests + a buildworld with D22987.66203.diff on r356250. No problems seen.

dougm updated this revision to Diff 66269.Jan 2 2020, 9:35 PM

Add an important omitted line.

pho added a comment.Jan 5 2020, 5:18 AM

I ran a full stress2 test on r356314 + D22987.66269.diff. No problems seen.

dougm added a reviewer: markj.Tue, Jan 21, 5:23 PM
dougm updated this revision to Diff 67217.Thu, Jan 23, 5:21 PM

Resolve conflicts.

markj accepted this revision.Thu, Jan 23, 5:51 PM

Seems reasonable to me.

sys/vm/vm_map.c
2418 ↗(On Diff #67217)

This line should be indented by four spaces.

3754 ↗(On Diff #67217)

This comment is still missing a period. I'm not sure it is very useful to begin with.

This revision is now accepted and ready to land.Thu, Jan 23, 5:51 PM