Fix regression in bsdinstall post r356740 - partedit errno(2) 21 EISDIR
ClosedPublic
Actions

Authored by woodsb02 on Jan 17 2020, 1:17 PM.

Details

Reviewers

bcran
darkfiberiru_gmail.com
freqlabs
emaste

Commits

rS356855: Fix regression in bsdinstall post r356740 - partedit errno(2) 21 EISDIR

Summary

Fix regression in bsdinstall post rS356740 - partedit errno(2) 21 EISDIR

This resulted in the partitioning step failing if either of the
"Auto (UFS)" or "Manual" options were selected, with error:

Abort
-----
Partioning error
An installation step has been aborted. Would you like
to restart the installation or exit the installer?

Reason:
partedit was attempting to open a directory (TMPDIR) read/write,
which resulted in errno(2) 21 - EISDIR - Is a directory.

# /usr/libexec/bsdinstall/partedit
partedit: /tmp: Is a directory

Test Plan

bsdinstall partedit - works ok
bsdinstall autopart - works ok

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28730
Build 26745: arc lint + arc unit

Event Timeline

woodsb02 created this revision.Jan 17 2020, 1:17 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 17 2020, 1:17 PM

Harbormaster completed remote builds in B28730: Diff 66907.Jan 17 2020, 1:17 PM

woodsb02 edited the summary of this revision. (Show Details)Jan 17 2020, 1:18 PM

woodsb02 edited the test plan for this revision. (Show Details)

woodsb02 retitled this revision from Fix regression in bsdinstall post r356740 - partedit errno(2) 21 EISDIR to Fix regression in bsdinstall post rS356740 - partedit errno(2) 21 EISDIR.Jan 17 2020, 1:21 PM

woodsb02 retitled this revision from Fix regression in bsdinstall post rS356740 - partedit errno(2) 21 EISDIR to Fix regression in bsdinstall post r356740 - partedit errno(2) 21 EISDIR.

woodsb02 edited the summary of this revision. (Show Details)

Sorry about that!

This revision is now accepted and ready to land.Jan 17 2020, 1:28 PM

Since I do not have a src commit bit (I am a ports committer), can a src committer please either commit this fix or provide approval for me to do so?