Build hard-float lib32 for mips64hf/mips64elhf
ClosedPublic
Actions

Authored by arichardson on Jan 17 2020, 11:11 AM.

Details

Reviewers

brooks
jhb

Commits

rS357170: Build hard-float lib32 for mips64hf/mips64elhf

Summary

This should fix linker error when building with clang+lld.

Test Plan

lib32 now builds with -mhard-float instead of -msoft-float

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28725
Build 26740: arc lint + arc unit

Event Timeline

arichardson created this revision.Jan 17 2020, 11:11 AM

Herald added subscribers: emaste, bdrewery. · View Herald TranscriptJan 17 2020, 11:11 AM

Harbormaster completed remote builds in B28725: Diff 66902.Jan 17 2020, 11:11 AM

arichardson added a child revision: D23204: Use Clang and LLD as the default toolchain for MIPS.Jan 17 2020, 11:12 AM

LGTM

This revision is now accepted and ready to land.Jan 17 2020, 11:50 AM

arichardson mentioned this in D23204: Use Clang and LLD as the default toolchain for MIPS.Jan 17 2020, 7:21 PM

Yes, I was testing this locally, though without the :=, just a plain =. I was testing it as part of a make tinderbox run though that is only on amd64 and hasn't gotten to mips, so hadn't seen breakage that would require :=.

In D23229#509463, @jhb wrote:

Yes, I was testing this locally, though without the :=, just a plain =. I was testing it as part of a make tinderbox run though that is only on amd64 and hasn't gotten to mips, so hadn't seen breakage that would require :=.

Yeah I got a recursive variable definition error with = so I changed it to :=

jhb accepted this revision.Jan 17 2020, 9:41 PM

jhb added inline comments.