Save and restore floating point registers in get/set_mcontext().
ClosedPublic
Actions

Authored by jhb on Jan 16 2020, 10:51 PM.

Details

Reviewers

andrew
br
mhorne
manu

Commits

rS356839: Save and restore floating point registers in get/set_mcontext().

Summary

arm64 and riscv were only saving and restoring floating point
registers for sendsig() and sys_sigreturn(), but not for getcontext(),
setcontext(), and swapcontext().

While here, remove a pointless check for uap being NULL from
sys_sigreturn().

Test Plan

booted riscv64 under spike which should exercise sendsig/sigreturn
have not tested arm64

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 28711
Build 26726: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 16 2020, 10:51 PM

Herald added a reviewer: manu. · View Herald TranscriptJan 16 2020, 10:51 PM

Herald added a subscriber: emaste. · View Herald Transcript

Harbormaster completed remote builds in B28711: Diff 66873.Jan 16 2020, 10:51 PM

mhorne accepted this revision.Jan 17 2020, 4:45 PM

This revision is now accepted and ready to land.Jan 17 2020, 4:45 PM

Just curious, why does spike in particular exercise sendsig/sigreturn?

br accepted this revision.Jan 17 2020, 4:57 PM

In D23218#509338, @mhorne wrote:

Just curious, why does spike in particular exercise sendsig/sigreturn?

I'm just assuming that booting multiuser involves catching at least one signal somewhere along the way.

Closed by commit rS356839: Save and restore floating point registers in get/set_mcontext(). (authored by jhb). · Explain WhyJan 17 2020, 7:02 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS356839: Save and restore floating point registers in get/set_mcontext()..

Herald added a subscriber: imp. · View Herald TranscriptJan 17 2020, 7:02 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

machdep.c

8 lines

riscv/

machdep.c

10 lines

Diff 66873

View Options

sys/arm64/arm64/machdep.c