Use falloc_noinstall + finstall.
ClosedPublic
Actions

Authored by jhb on Jan 8 2020, 12:27 AM.

Details

Reviewers

kib
cem
jmg

Commits

rS356508: Use falloc_noinstall + finstall for crypto file descriptors.

Test Plan

cryptocheck still passes ok

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 8 2020, 12:27 AM

Harbormaster completed remote builds in B28529: Diff 66471.Jan 8 2020, 12:27 AM

I guess this race doesn't really matter as if you try to use the file before finit() you just get badfileops and finit() itself is "atomic"? If so, I could just leave this as-is unless this approach is preferred.

No objection, but I believe you're correct about finit() being "atomic." (I mean, it is atomic. But are the fops consumers?)

sys/opencrypto/cryptodev.c
1516 ↗	(On Diff #66471)	Will the compiler complain about storing `fd` to a `uint32_t` lvalue? I guess that part has not changed, so no.

This revision is now accepted and ready to land.Jan 8 2020, 1:05 AM

kib accepted this revision.Jan 8 2020, 9:23 AM

Closed by commit rS356508: Use falloc_noinstall + finstall for crypto file descriptors. (authored by jhb). · Explain WhyJan 8 2020, 7:03 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS356508: Use falloc_noinstall + finstall for crypto file descriptors..

Herald added a reviewer: jmg. · View Herald TranscriptJan 8 2020, 7:03 PM

Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

head/

sys/

opencrypto/

cryptodev.c

15 lines

Diff 66510

View Options

head/sys/opencrypto/cryptodev.c

Use falloc_noinstall + finstall.ClosedPublicActions