Page MenuHomeFreeBSD

Use falloc_noinstall + finstall.
ClosedPublic

Authored by jhb on Jan 8 2020, 12:27 AM.

Details

Test Plan
  • cryptocheck still passes ok

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb created this revision.Jan 8 2020, 12:27 AM

I guess this race doesn't really matter as if you try to use the file before finit() you just get badfileops and finit() itself is "atomic"? If so, I could just leave this as-is unless this approach is preferred.

cem accepted this revision.Jan 8 2020, 1:05 AM

No objection, but I believe you're correct about finit() being "atomic." (I mean, it is atomic. But are the fops consumers?)

sys/opencrypto/cryptodev.c
1516 ↗(On Diff #66471)

Will the compiler complain about storing fd to a uint32_t lvalue? I guess that part has not changed, so no.

This revision is now accepted and ready to land.Jan 8 2020, 1:05 AM
kib accepted this revision.Jan 8 2020, 9:23 AM
This revision was automatically updated to reflect the committed changes.