Page MenuHomeFreeBSD

Use falloc_noinstall + finstall.
ClosedPublic

Authored by jhb on Jan 8 2020, 12:27 AM.
Tags
None
Referenced Files
F109252933: D23078.diff
Sun, Feb 2, 3:54 PM
Unknown Object (File)
Sun, Jan 26, 9:35 PM
Unknown Object (File)
Thu, Jan 23, 3:14 AM
Unknown Object (File)
Thu, Jan 23, 3:14 AM
Unknown Object (File)
Wed, Jan 22, 11:56 PM
Unknown Object (File)
Dec 25 2024, 9:31 PM
Unknown Object (File)
Dec 20 2024, 8:32 AM
Unknown Object (File)
Oct 8 2024, 10:09 PM
Subscribers

Details

Test Plan
  • cryptocheck still passes ok

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 28529
Build 26582: arc lint + arc unit

Event Timeline

I guess this race doesn't really matter as if you try to use the file before finit() you just get badfileops and finit() itself is "atomic"? If so, I could just leave this as-is unless this approach is preferred.

No objection, but I believe you're correct about finit() being "atomic." (I mean, it is atomic. But are the fops consumers?)

sys/opencrypto/cryptodev.c
1516

Will the compiler complain about storing fd to a uint32_t lvalue? I guess that part has not changed, so no.

This revision is now accepted and ready to land.Jan 8 2020, 1:05 AM