Move all MD statements into $MACHINE_ARCH/Makefile.inc.
Unconditionally apply version script to rtld, it is not functional without it for long time.
Details
Details
- Reviewers
brooks emaste - Commits
- rS356631: rtld: clean up Makefile.
So far a limited testing was done. Tinderbox is due, at least.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 28538
Event Timeline
Comment Actions
This looks good, part from the one question I had.
| libexec/rtld-elf/Makefile | ||
|---|---|---|
| 84 | Is removing the non-symbol versioning support intentional? | |
| libexec/rtld-elf/Makefile | ||
|---|---|---|
| 44 | -nostdlib seems like it should be here not duplicated. I'd be tempted to make this: LDFLAGS+= -nostdlib -e ${RTLD_ENTRY}
...
.sinclude "${RTLD_ELF_DIR}/${RTLD_ARCH}/Makefile.inc"
RTLD_ENTRY?=.rtld_startwith an overriding in the powerpc file(s). | |
| 59 | Given that sparc64 is heading for the dumpster, I'd be tempted to add -fpic below and a CFLAGS:=${CFLAGS:S/-fpic/-fPIC} in sparc64/Makefile.inc. | |
Comment Actions
Looks good to me other than the minor issue on sparc64.
| libexec/rtld-elf/sparc64/Makefile.inc | ||
|---|---|---|
| 3 | I think there's a missing / at the end. | |
| libexec/rtld-elf/arm/Makefile.inc | ||
|---|---|---|
| 4–5 | this "placed first" comment seems confusing in that I don't see what's supposed to ensure that it's placed first. but it doesn't appear to be new in your change. | |