Do not define TCPOUTFLAGS in rack_bbr_common.c
ClosedPublic
Actions

Authored by emaste on Jan 7 2020, 5:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 11, 11:54 PM

	Unknown Object (File)
	Sat, Apr 11, 10:03 PM

	Unknown Object (File)
	Fri, Apr 10, 8:41 AM

	Unknown Object (File)
	Thu, Apr 9, 9:24 PM

	Unknown Object (File)
	Mon, Apr 6, 4:01 AM

	Unknown Object (File)
	Sun, Apr 5, 1:23 PM

	Unknown Object (File)
	Mon, Mar 30, 8:16 PM

	Unknown Object (File)
	Mon, Mar 30, 7:07 PM

View All Files

Subscribers

imp

Details

Reviewers

rrs
tuexen

Group Reviewers

transport

Commits

rS356459: Do not define TCPOUTFLAGS in rack_bbr_common

Summary

tcp_outflags isn't used in this source file and compilation failed with external GCC on sparc64 with:

In file included from .../rack_bbr_common.c:96:0:
.../tcp_fsm.h:88:15: error: 'tcp_outflags' defined but not used ...

static u_char tcp_outflags[TCP_NSTATES] = {
              ^~~~~~~~~~~~

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.Jan 7 2020, 5:09 PM

Herald added a reviewer: transport. · View Herald TranscriptJan 7 2020, 5:09 PM

tuexen accepted this revision.Jan 7 2020, 5:36 PM

This revision is now accepted and ready to land.Jan 7 2020, 5:36 PM

Closed by commit rS356459: Do not define TCPOUTFLAGS in rack_bbr_common (authored by emaste). · Explain WhyJan 7 2020, 5:57 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rS356459: Do not define TCPOUTFLAGS in rack_bbr_common.

Herald added a subscriber: imp. · View Herald TranscriptJan 7 2020, 5:57 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

tcp_stacks/

rack_bbr_common.c

1 line

Diff 66452

View Options

head/sys/netinet/tcp_stacks/rack_bbr_common.c

Do not define TCPOUTFLAGS in rack_bbr_common.cClosedPublicActions