Do not define TCPOUTFLAGS in rack_bbr_common.c
ClosedPublic
Actions

Authored by emaste on Jan 7 2020, 5:09 PM.

Tags

None

Referenced Files

	F103460721: D23068.id66447.diff
	Mon, Nov 25, 8:02 AM

	Unknown Object (File)
	Sun, Nov 24, 4:05 AM

	Unknown Object (File)
	Sat, Nov 23, 9:45 AM

	Unknown Object (File)
	Fri, Nov 22, 11:33 PM

	Unknown Object (File)
	Mon, Nov 18, 1:23 AM

	Unknown Object (File)
	Sun, Nov 17, 10:52 PM

	Unknown Object (File)
	Thu, Nov 14, 5:24 AM

	Unknown Object (File)
	Wed, Nov 13, 5:31 AM

View All 52 Files

Subscribers

imp

Details

Reviewers

rrs
tuexen

Group Reviewers

transport

Commits

rS356459: Do not define TCPOUTFLAGS in rack_bbr_common

Summary

tcp_outflags isn't used in this source file and compilation failed with external GCC on sparc64 with:

In file included from .../rack_bbr_common.c:96:0:
.../tcp_fsm.h:88:15: error: 'tcp_outflags' defined but not used ...

static u_char tcp_outflags[TCP_NSTATES] = {
              ^~~~~~~~~~~~

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Jan 7 2020, 5:09 PM

Herald added a reviewer: transport. · View Herald TranscriptJan 7 2020, 5:09 PM

tuexen accepted this revision.Jan 7 2020, 5:36 PM

This revision is now accepted and ready to land.Jan 7 2020, 5:36 PM

Closed by commit rS356459: Do not define TCPOUTFLAGS in rack_bbr_common (authored by emaste). · Explain WhyJan 7 2020, 5:57 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rS356459: Do not define TCPOUTFLAGS in rack_bbr_common.

Herald added a subscriber: imp. · View Herald TranscriptJan 7 2020, 5:57 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

rack_bbr_common.c

1 line

Diff 66447

View Options

sys/netinet/tcp_stacks/rack_bbr_common.c

Do not define TCPOUTFLAGS in rack_bbr_common.cClosedPublicActions