Define a function combining vm entry lookup and clip-start
ClosedPublic
Actions

Authored by dougm on Jan 1 2020, 7:48 AM.

Details

Reviewers

alc
markj

Commits

rS357073: Most uses of vm_map_clip_start follow a call to vm_map_lookup. Define

Summary

Most uses of vm_map_clip_start follow a call to vm_map_lookup. Define an inline function vm_map_lookup_clip_start that invokes them both and use it in places that invoke both. Drop a couple of local variables made unnecessary by this function.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dougm created this revision.Jan 1 2020, 7:48 AM

I ran a preliminary 5 hour tests + a buildworld with D22987.66203.diff on r356250. No problems seen.

Add an important omitted line.

I ran a full stress2 test on r356314 + D22987.66269.diff. No problems seen.

dougm added a reviewer: markj.Jan 21 2020, 5:23 PM

Resolve conflicts.

Seems reasonable to me.

sys/vm/vm_map.c
2418	This line should be indented by four spaces.
3757	This comment is still missing a period. I'm not sure it is very useful to begin with.

This revision is now accepted and ready to land.Jan 23 2020, 5:51 PM

Closed by commit rS357073: Most uses of vm_map_clip_start follow a call to vm_map_lookup. Define (authored by dougm). · Explain WhyJan 24 2020, 7:48 AM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rS357073: Most uses of vm_map_clip_start follow a call to vm_map_lookup. Define.

Herald added a subscriber: imp. · View Herald TranscriptJan 24 2020, 7:48 AM

Revision Contents
Changeset List

Path

Size

sys/

vm/

vm_map.c

94 lines

Diff 66269

View Options

Define a function combining vm entry lookup and clip-startClosedPublicActions